Repository navigation
[dotnet] Don't quote the 'RunCommand' property. - #25764
Conversation
The 'RunCommand' property is supposed to be the path to a single executable, and as such should not be quoted. See: dotnet/sdk#54917 (comment)
There was a problem hiding this comment.
Pull request overview
Updates the .NET mobile SDK MSBuild targets so dotnet run receives an unquoted RunCommand (a single executable path), aligning with the SDK’s expectation that quoting is handled by the runner rather than embedded in the property value.
Changes:
- Remove surrounding single quotes from
RunCommandwhen setting it to$(MlaunchPath)inMicrosoft.Sdk.Mobile.targets.
✅ [PR Build #fe75fd9] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [PR Build #fe75fd9] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #fe75fd9] Build passed (Build packages) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [PR Build #fe75fd9] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #fe75fd9] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 207 tests passed 🎉 Tests counts✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
The 'RunCommand' property is supposed to be the path to a single executable, and as such should not be quoted. See: dotnet/sdk#54917 (comment)
After cherry-picking PR #25764 which removes quotes from RunCommand, update the MlaunchTest assertion to expect the unquoted path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The 'RunCommand' property is supposed to be the path to a single executable, and as such should not be quoted.
See: dotnet/sdk#54917 (comment)