Skip to content

[build] Only report build failures, not successes - #25959

Merged
rolfbjarne merged 1 commit into
mainfrom
dev/rolf/skip-success-build-comment
Jul 7, 2026
Merged

rolfbjarne merged 1 commit into
mainfrom
dev/rolf/skip-success-build-comment

Conversation

@rolfbjarne

@rolfbjarne rolfbjarne commented Jul 7, 2026 •

Copy link
Copy Markdown
Member

The 'Report build result' step no longer posts a GitHub comment when the build succeeds - only when it fails.

These "Build passed" comments (and emails) don't add much value, so just remove them. We're still interested in failures though, so those will still be posted.

πŸ€– Pull request created by Copilot

The 'Report build result' step no longer posts a GitHub comment
when the build succeeds - only when it fails.

These "Build passed" comments (and emails) don't add much value, so just
remove them. We're still interested in failures though, so those will still be
posted.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@rolfbjarne
rolfbjarne marked this pull request as ready for review July 7, 2026 13:59
Copilot AI review requested due to automatic review settings July 7, 2026 13:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Azure Pipelines build template to reduce noise by stopping the β€œReport build result” step from posting GitHub comments (and triggering notifications) on successful builds, while still reporting failures.

Changes:

  • Add an early-exit in the β€œReport build result” PowerShell step when the job succeeds.
  • Simplify the reporting logic to always construct a β€œBuild failed” comment when reporting occurs.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

βœ… API diff for current PR / commit

NET (empty diffs)

βœ… API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: c0213779b2177b20d0fc30ffb81cc488e50c41fa [PR build]

@rolfbjarne
rolfbjarne enabled auto-merge (squash) July 7, 2026 16:28
@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸš€ [CI Build #c021377] Test results πŸš€

Test results

βœ… All tests passed on VSTS: test results.

πŸŽ‰ All 199 tests passed πŸŽ‰

Tests counts

βœ… assembly-processing: All 1 tests passed. Html Report (VSDrops) Download
βœ… cecil: All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
βœ… framework: All 2 tests passed. Html Report (VSDrops) Download
βœ… fsharp: All 4 tests passed. Html Report (VSDrops) Download
βœ… generator: All 5 tests passed. Html Report (VSDrops) Download
βœ… interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
βœ… introspection: All 4 tests passed. Html Report (VSDrops) Download
βœ… linker (iOS): All 15 tests passed. Html Report (VSDrops) Download
βœ… linker (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
βœ… linker (macOS): All 21 tests passed. Html Report (VSDrops) Download
βœ… linker (tvOS): All 15 tests passed. Html Report (VSDrops) Download
βœ… monotouch (iOS): All 18 tests passed. Html Report (VSDrops) Download
βœ… monotouch (MacCatalyst): All 17 tests passed. Html Report (VSDrops) Download
βœ… monotouch (macOS): All 18 tests passed. Html Report (VSDrops) Download
βœ… monotouch (tvOS): All 18 tests passed. Html Report (VSDrops) Download
βœ… msbuild: All 2 tests passed. Html Report (VSDrops) Download
βœ… sharpie: All 1 tests passed. Html Report (VSDrops) Download
βœ… windows: All 3 tests passed. Html Report (VSDrops) Download
βœ… xcframework: All 4 tests passed. Html Report (VSDrops) Download
βœ… xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

βœ… Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
βœ… Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
βœ… Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
βœ… Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
βœ… Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

βœ… Linux build succeeded

Pipeline on Agent
Hash: c0213779b2177b20d0fc30ffb81cc488e50c41fa [PR build]

@rolfbjarne
rolfbjarne merged commit 6d24fb6 into main Jul 7, 2026
56 of 57 checks passed
@rolfbjarne
rolfbjarne deleted the dev/rolf/skip-success-build-comment branch July 7, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants