Skip to content

[AppKit] Document ten enum types - #26557

Merged
rolfbjarne merged 16 commits into
mainfrom
dev/rolf/xmldocs-055-batch
Sep 4, 2026
Merged

[AppKit] Document ten enum types#26557
rolfbjarne merged 16 commits into
mainfrom
dev/rolf/xmldocs-055-batch

Conversation

@rolfbjarne

@rolfbjarne rolfbjarne commented Sep 3, 2026

Copy link
Copy Markdown
Member

Document ten AppKit enum types and their members, replacing placeholder documentation with useful summaries.

Remove the corresponding entries from the Cecil documentation known-failures list.

🤖 Pull request created by Copilot

@rolfbjarne
[AppKit] Document NSRunResponse
da7c3aa 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
@rolfbjarne
[AppKit] Document NSTextTabType
15b43e9 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
@rolfbjarne
[AppKit] Document NSWindowNumberListOptions
40fac4c 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
@rolfbjarne
[AppKit] Document NSSelectionDirection
4a9c6a5 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
@rolfbjarne
[AppKit] Document NSTableViewSelectionHighlightStyle
84c59a5 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
@rolfbjarne
[AppKit] Document NSTableViewGridStyle
f5e044d 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
@rolfbjarne
[AppKit] Document NSImageFrameStyle
ab1d668 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
@rolfbjarne
[AppKit] Document NSSpeechBoundary
0d660c1 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
@rolfbjarne
[AppKit] Document NSSplitViewDividerStyle
6a4087c 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
@rolfbjarne
[AppKit] Document NSImageScaling
7f48822 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
@rolfbjarne
[AppKit] Clarify NSTextTabType alignment
6f616d3 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
@rolfbjarne
[AppKit] Clarify NSSpeechBoundary behavior
b556580 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
@rolfbjarne
[AppKit] Clarify NSRunResponse semantics
112572d 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
@rolfbjarne
[AppKit] Clarify NSSelectionDirection.Direct
ab9bfc7 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
@rolfbjarne
[AppKit] Clarify NSSelectionDirection traversal
ff0e0ee 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
Copilot AI lite review requested due to automatic review settings September 3, 2026 16:37
Copilot AI reviewed Sep 3, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Changes are documentation-only and the known-failures list updates appear consistent with the newly documented enum types.

Pull request overview

Updates AppKit binding documentation by replacing placeholder enum XML docs with meaningful summaries, and aligns the Cecil documentation test expectations by removing the corresponding known-failure entries.

Changes:

  • Added enum- and member-level XML documentation for 10 AppKit enum types in src/AppKit/Enums.cs.
  • Removed the documented AppKit enum types from tests/cecil-tests/Documentation.KnownFailures.txt so Cecil doc tests no longer treat them as expected failures.
File summaries
File Description
tests/cecil-tests/Documentation.KnownFailures.txt Removes the now-documented AppKit enum type entries from the Cecil documentation known-failures list.
src/AppKit/Enums.cs Replaces “To be added.” placeholders with useful <summary> documentation for 10 AppKit enums and their members.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment thread src/AppKit/Enums.cs Resolved
@rolfbjarne
[AppKit] Clarify NSWindowNumberListOptions scope
c3d7d5e 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: c3d7d5ed40ba313dcd28f8e99de0dfe976c92010 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

🚀 [CI Build #c3d7d5e] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 264 tests passed 🎉

Tests counts

✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 7 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 31 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 31 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 21 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 31 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 25 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 25 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 20 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: c3d7d5ed40ba313dcd28f8e99de0dfe976c92010 [PR build]

@rolfbjarne rolfbjarne added the ready-to-review This PR is ready to review/merge. label Sep 4, 2026
@rolfbjarne
rolfbjarne enabled auto-merge (squash) September 4, 2026 06:49
@rolfbjarne
rolfbjarne merged commit 063ceee into main Sep 4, 2026
54 checks passed
@rolfbjarne
rolfbjarne deleted the dev/rolf/xmldocs-055-batch branch September 4, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@dalexsoto dalexsoto dalexsoto approved these changes

Assignees

No one assigned

Labels

copilot ready-to-review This PR is ready to review/merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto