Repository navigation
[release/10.0.1xx] [introspection] Update for recent changes in macOS 27. - #26647
Conversation
Allow the valid genlock synchronization term on macOS and Mac Catalyst, and skip the AVCaptureDevice lens-position bias setter that is declared in the Xcode 27 headers but absent from both runtimes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2a785732-cba6-48b5-a0fc-6530479473e7
There was a problem hiding this comment.
🟡 Changes recommended
The macOS selector exception should be scoped to the affected macOS 27 runtime.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates introspection tests for macOS 27 and Mac Catalyst 27 API/runtime differences.
Changes:
- Allows the valid
Genlocksynchronization term. - Skips the unavailable
AVCaptureDevicelens-position bias setter.
File summaries
| File | Summary |
|---|---|
tests/introspection/MacApiSelectorTest.cs |
Skips the missing macOS selector. Moderate (1 vote): scope the exception to macOS 27. Nit (2 votes): fold it into the existing selector switch. |
tests/introspection/iOSApiSelectorTest.cs |
Skips the missing Mac Catalyst selector. |
tests/introspection/ApiTypoTest.cs |
Allows the valid Genlock term. |
Review details
Suppressed comments (1)
tests/introspection/MacApiSelectorTest.cs:121
- 💡 Maintainability — This skip is unconditional, so it will keep suppressing the selector on every future macOS runtime even after Apple implements it, preventing introspection from detecting that support. Please scope the exception to the affected macOS 27 runtime (or otherwise make it self-expiring), consistent with the version-gated exceptions elsewhere in this file.
if (type.Name == "AVCaptureDevice" && selectorName == "setContinuousAutoFocusTrackingLensPositionBias:")
// This setter is declared for macOS 27 but is not implemented in the macOS 27 runtime.
return true;
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
🚀 [CI Build #64228eb] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 195 tests passed 🎉 Tests counts✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
Allow the valid genlock synchronization term on macOS and Mac Catalyst, and skip the AVCaptureDevice lens-position bias setter that is declared in the Xcode 27 headers but absent from both runtimes.
Copilot-Session: 2a785732-cba6-48b5-a0fc-6530479473e7
Backport of #26645.