🔴 Live TV: dotnet/macios/pull/

rolfbjarne · 2026-09-22T13:10:47Z

Document ten active AppKit delegate types and remove their corresponding entries from the Cecil documentation known-failure baseline.

The batch covers application window enumeration and activity restoration, document completion and open-panel callbacks, event monitors, custom image drawing, and candidate-list formatting.

Validation:

Reviewed the modified XML documentation with the xml-doc-writer workflow.
Verified the delegate semantics against the installed AppKit SDK headers.
Verified every delegate parameter and return value is documented.
Verified all ten corresponding Cecil baseline entries were removed.
Verified the diff contains 25 additions and 10 deletions, within the 100-line batch limit.
The targeted Cecil test could not run locally because the repository .NET SDK is not installed; CI will provide executable coverage.

🤖 Pull request created by Copilot

Describe the enumerated window and the stop flag used to terminate application window enumeration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442

Describe the restorable objects supplied when continuing a user activity. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442

Describe the native error pointer reported when an asynchronous document operation completes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442

Describe the event delivered to an AppKit global event monitor. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442

Describe how local event monitors return an event for dispatch or suppress it by returning null. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442

Describe the destination rectangle and success result for custom image drawing callbacks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442

Describe the error supplied when an asynchronous document lock operation completes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442

Describe the URLs selected when the document controller's open panel completes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442

Describe the modal response reported by a document controller open panel. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442

Describe the candidate and index inputs and the attributed string returned for display. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442

Follow the repository XML documentation layout so the delegate documentation precedes its availability attribute. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442

Clarify that the document controller supplies a null URL array when the user cancels the open panel, matching the AppKit header contract. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442

Copilot

Copilot review overview

🟡 Changes recommended

Three documented nullable callback values contradict non-nullable binding declarations until nullability annotations are added.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1

Open (1)

Mark nullable callback return with [NullAllowed] · New

What changed in this PR

Documents ten AppKit delegate types and removes their Cecil documentation baseline entries.

Changes:

Added XML documentation for delegate parameters and return values.
Removed ten corresponding known-failure entries.

File	Description
`src/appkit.cs`	Adds documentation for ten AppKit delegates.
`tests/cecil-tests/Documentation.KnownFailures.txt`	Removes resolved documentation failures.

vs-mobiletools-engineering-service2 · 2026-09-22T16:09:42Z

⚠️ AppSizeTest expected files changed ⚠️

The AppSizeTest detected changes in the expected app size files.

To update the expected files, add a comment with the following command:

/apply-gist https://gist.github.com/vs-mobiletools-engineering-service2/57299f17f82d96ac7c671dd055ddf451

Updated files

MacOSX-CoreCLR-R2R-size.txt

Pipeline on Agent
Hash: 95d84d25644bebb90b1612c023298cc90086e93e [PR build]

Copilot

Copilot review overview

🟢 Approval recommended

The remaining documentation nit is non-blocking.

Review effort: Lite
Findings: None

Resolved since last review (1)

Mark nullable callback return with [NullAllowed]

vs-mobiletools-engineering-service2 · 2026-09-23T14:56:24Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: c68e18446410437640b16187ba4b797ccc88b4c6 [PR build]

vs-mobiletools-engineering-service2 · 2026-09-24T18:53:16Z

🚀 [CI Build #c68e184] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 269 tests passed 🎉

Tests counts

✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 7 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 31 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 31 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 21 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 31 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 25 tests passed. [attempt 5] Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 25 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 20 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Golden Gate (27): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: c68e18446410437640b16187ba4b797ccc88b4c6 [PR build]

rolfbjarne added 14 commits September 22, 2026 15:05

[AppKit] Document NSApplicationEnumerateWindowsHandler

5740928

Describe the enumerated window and the stop flag used to terminate application window enumeration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442

[AppKit] Document ContinueUserActivityRestorationHandler

1ef184c

Describe the restorable objects supplied when continuing a user activity. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442

[AppKit] Document NSDocumentCompletionHandler

d2aef1a

Describe the native error pointer reported when an asynchronous document operation completes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442

[AppKit] Document GlobalEventHandler

19e2e43

Describe the event delivered to an AppKit global event monitor. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442

[AppKit] Document LocalEventHandler

ae39b77

Describe how local event monitors return an event for dispatch or suppress it by returning null. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442

[AppKit] Document NSCustomImageRepDrawingHandler

182075e

Describe the destination rectangle and success result for custom image drawing callbacks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442

[AppKit] Document NSDocumentLockCompletionHandler

ca721dd

Describe the error supplied when an asynchronous document lock operation completes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442

[AppKit] Document NSDocumentControllerOpenPanelWithCompletionHandler

68d8160

Describe the URLs selected when the document controller's open panel completes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442

[AppKit] Document NSDocumentControllerOpenPanelResultHandler

26ee299

Describe the modal response reported by a document controller open panel. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442

[AppKit] Document AttributedStringForCandidateHandler

1e655d1

Describe the candidate and index inputs and the attributed string returned for display. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442

Copilot AI lite review requested due to automatic review settings September 22, 2026 13:10

rolfbjarne requested a review from dalexsoto as a code owner September 22, 2026 13:10

rolfbjarne added the copilot label Sep 22, 2026

Copilot started reviewing on behalf of rolfbjarne September 22, 2026 13:11

View session

Copilot AI reviewed Sep 22, 2026

View reviewed changes

Comment thread src/appkit.cs Resolved

rolfbjarne mentioned this pull request Sep 22, 2026

[AppKit] Add nullable annotations to callback delegates #26678

Closed

This comment has been minimized.

Sign in to view

Merge branch 'main' into dev/rolf/xmldocs-062

c68e184

Copilot AI review requested due to automatic review settings September 23, 2026 14:18

Copilot started reviewing on behalf of rolfbjarne September 23, 2026 14:19

View session

rolfbjarne enabled auto-merge (squash) September 23, 2026 14:20

rolfbjarne added the ready-to-review This PR is ready to review/merge. label Sep 23, 2026

Copilot AI reviewed Sep 23, 2026

View reviewed changes

dalexsoto approved these changes Sep 23, 2026

View reviewed changes

This was referenced Sep 23, 2026

[CI] Parallel MonoTouch.Dialog Csc writes cause MSB3026 in PublishAotMonoTouchTest #26688

Closed

[CI] iOS 27 SpringBoard RBSAssertion crash causes app launch timeout #26227

Open

[CI] Sonoma Clean bot hangs in simctl delete all for 60 minutes #26525

Open

This comment has been minimized.

Sign in to view

dalexsoto mentioned this pull request Sep 23, 2026

[CI] NativeAOT CGImageMetadataTest crashes retaining CGImageMetadataTag proxy #26545

Closed

This comment has been minimized.

Sign in to view

rolfbjarne merged commit d8d90c6 into main Sep 24, 2026
56 checks passed

rolfbjarne deleted the dev/rolf/xmldocs-062 branch September 24, 2026 18:54

Navigation Menu

Repository navigation

[AppKit] Add XML docs for ten delegates - #26677

[AppKit] Add XML docs for ten delegates#26677
rolfbjarne merged 15 commits into
mainfrom
dev/rolf/xmldocs-062

rolfbjarne commented Sep 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Sep 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 23, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Sep 24, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

rolfbjarne commented Sep 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Sep 22, 2026

⚠️ AppSizeTest expected files changed ⚠️

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 23, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Sep 24, 2026

🚀 [CI Build #c68e184] Test results 🚀

Test results

Tests counts

macOS tests

Linux Build Verification

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants