[mattleibow]

PENDING PRs:

1. Use [AppendTo|PrependTo|Replace]Mapping for Focus commands #15040
2. Use PrependToMapping method to replace Window MapTitle method #15041
3. Implement all permutations of InputTransparent and CascadeInputTransparent #14846
4. Ensure "text boxes" preserve cursor location #15099
5. Implement all permutations of InputTransparent and CascadeInputTransparent #14846
6. Text needs to be set before other properties #16116
7. Move most controls to use ModifyMapping (and variants) #15058

Description of Change

Update mappers instead of replacing field values to prevent field/type reference ordering to influence the way mappers are set.

Currently we assume that UseMauiApp is the first part of MAUI that updates the mappers, however we can directly influence that very easily:

// load Core mappers
ElementHandler.ElementMapper.GetKeys();
ViewHandler.ViewMapper.GetKeys();
ButtonHandler.Mapper.GetKeys();

// then load Controls mappers
Button.ControlsButtonMapper.GetKeys();
Element.ControlsElementMapper.GetKeys();
VisualElement.ControlsVisualElementMapper.GetKeys();

By first forcing all the Core types to load, the Controls mappers are not correctly set up to handle changes later on. Because we first load Button.ControlsButtonMapper and then Element.ControlsElementMapper, the properties in Element are not available to Button.

This PR removes the need for ordering and makes sure that Button is chained to Element so we can ADD to Element and Button automatically gets the new properties.

Context: #11662 (comment)

BREAKING

There is technically a breaking change in that we are no longer use the Controls*Mapper fields anymore since they actually break with AOT as they would run in random orders (hence this PR). So as a result, if someone did this, it would no longer work:

Button.ControlsButtonMapper.AppendToMapping(...);

The reason for this is that we don't use this field and thus would never reach the handlers. However, I am not sure this way is common as most people should have been using the base mapper:

ButtonHandler.Mapper.AppendToMapping(...);

To help avoid and catch any of these issues, I have marked it as obsolete so that there is a build warning. However, regardless of what version of maui you are using, always use the base handler mappers.

Issues Fixed

Fixes #11662

Tasks

• Code
  • Application.RemapForControls();
  • VisualElement.RemapForControls();
  • Label.RemapForControls();
  • Button.RemapForControls();
  • CheckBox.RemapForControls();
  • DatePicker.RemapForControls();
  • RadioButton.RemapForControls();
  • FlyoutPage.RemapForControls();
  • Toolbar.RemapForControls();
  • Window.RemapForControls();
  • Editor.RemapForControls();
  • Entry.RemapForControls();
  • Picker.RemapForControls();
  • SearchBar.RemapForControls();
  • TabbedPage.RemapForControls();
  • TimePicker.RemapForControls();
  • Layout.RemapForControls();
  • ScrollView.RemapForControls();
  • RefreshView.RemapForControls();
  • Shape.RemapForControls();
  • WebView.RemapForControls();
• Tests

[github-actions]

Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines.

[ghost]

🚨 API change(s) detected @davidbritch FYI

[mattleibow]

/rebase

[github-actions]

Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines.

[github-actions]

Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines.

[PureWeen]

I kicked off some extra UI Tests here

https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8126594&view=results

If those don't seem to have any additional fails beyond what we're currently fixing, then I'd say merge.

[jknaudt21]

Would be great to see doc comments for the new mappers, but I don't want to block a merge because of it.

[mattleibow]

I will start mapper docs here: #16296

Still need to figure out the best way...

🧑‍🤝‍🧑