Repository navigation
Remove view from previous containerview - #14867
Merged
Merged
Conversation
PureWeen
marked this pull request as ready for review
May 2, 2023 17:24
PureWeen
marked this pull request as draft
May 2, 2023 17:29
PureWeen
marked this pull request as ready for review
May 2, 2023 20:38
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
PureWeen
added
partner/cat 😻
hartez
approved these changes
May 8, 2023
rmarinho
pushed a commit
that referenced
this pull request
May 30, 2023
* Remove view from previous containerview * - fix shell test to correctly add nav bar * - fix wiring up to modal pages * - fix extraction of currentpage
1 task
samhouts
added
the
fixed-in-8.0.0-preview.5.8529
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
ContainerViewonAndroid, so that we remove the view from the previousContainerView. This primarily happens if you reuse the same instance of a page for theWindow.PageToolbarproperty on the correct MAUI xplat view. When this code was previously written we didn't have theWindowChangedevent to work with so it made the timing tricky when to triggerNavigationPageto remove/add a toolbar. With this new code we are able to add/remove the toolbar in a more logical location.Issues Fixed
Fixes #14866