Skip to content

Enable default xcode path - #16708

Merged
rmarinho merged 3 commits into
mainfrom
enable_default_xcode_path
Aug 14, 2023
Merged

rmarinho merged 3 commits into
mainfrom
enable_default_xcode_path

Conversation

@PureWeen

Copy link
Copy Markdown
Member

Description of Change

When running device tests the Xcode path is hardcoded to a specific XCODE with a suffix of the version. This change makes it so when running locally we just leave that off or the user can pass in the XCODE argument themselves

@PureWeen
PureWeen requested a review from a team as a code owner August 11, 2023 21:23
@PureWeen
PureWeen requested review from BretJohnson, hartez, jfversluis, mattleibow and rmarinho and removed request for hartez and jfversluis August 11, 2023 21:23
@rmarinho
rmarinho merged commit a7e99ae into main Aug 14, 2023
@rmarinho
rmarinho deleted the enable_default_xcode_path branch August 14, 2023 13:25
rmarinho pushed a commit that referenced this pull request Aug 19, 2023
* If specific XCODE path isn't found don't include it on args

* - always include args for CI build

* - cleanup
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 7, 2023
@samhouts samhouts added the fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants