Skip to content

Add a "VSCode" target to open the "maui.code-workspace". - #16732

Merged
rmarinho merged 2 commits into
dotnet:mainfrom
dellis1972:openvscode
Aug 18, 2023
Merged

rmarinho merged 2 commits into
dotnet:mainfrom
dellis1972:openvscode

Conversation

@dellis1972

Copy link
Copy Markdown
Contributor

This commit adds a new --target for the cake script which
will open Visual Studio Code after a build.

dotnet cake --target=VSCode --workloads=global

@dellis1972
dellis1972 requested a review from a team as a code owner August 14, 2023 09:46
@jfversluis

Copy link
Copy Markdown
Member

This is cool, thank you!

Should we also have a VS Code Insiders one? Or somehow detect if someone is using Insiders version? Maybe I'm taking it too far then 😄

@dellis1972

Copy link
Copy Markdown
Contributor Author

This is cool, thank you!

Should we also have a VS Code Insiders one? Or somehow detect if someone is using Insiders version? Maybe I'm taking it too far then 😄

I'm not entirely sure how to detect the different versions. This implementation just assumes that code is on the path. I imagine if we needed to search for different versions, it would get allot more complicated.

@MartyIX

MartyIX commented Aug 14, 2023

Copy link
Copy Markdown
Contributor

On Windows, there is

C:\Users\<USER>\AppData\Local\Programs\Microsoft VS Code Insiders\bin\code-insiders.cmd

so one can start code-insiders process similarly as code is run, I guess. Personally, it feels a bit excessive though.

@Eilon Eilon added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Aug 15, 2023
@rmarinho

Copy link
Copy Markdown
Member

/rebase

This commit adds a new --target for the cake script which
will open Visual Studio Code after a build.

```
dotnet cake --target=VSCode --workloads=global
```
@mattleibow

Copy link
Copy Markdown
Member

I only use insiders...

@mattleibow

Copy link
Copy Markdown
Member

Unless we add a VSCodeInsiders target too :)

@dellis1972

Copy link
Copy Markdown
Contributor Author

Is there a way to add a flag using cake?

Then perhaps we can do

dotnet cake --target=VSCode --insiders --workloads=global

or

dotnet cake --target=VSCode --preview --workloads=global

@rmarinho
rmarinho merged commit e6630ee into dotnet:main Aug 18, 2023
rmarinho pushed a commit that referenced this pull request Aug 19, 2023
* Add a "VSCode" target to open the "maui.code-workspace".

This commit adds a new --target for the cake script which
will open Visual Studio Code after a build.

```
dotnet cake --target=VSCode --workloads=global
```

* Update Documents
@dellis1972
dellis1972 deleted the openvscode branch August 19, 2023 13:48
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 7, 2023
@samhouts samhouts added the fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants