Repository navigation
[BuildTasks] Fix resolution for nested types - #16841
Merged
Merged
Conversation
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
requested review from
StephaneDelcroix
and removed request for
rachelkang
August 18, 2023 14:51
jonathanpeppers
previously approved these changes
Aug 18, 2023
Fixes: dotnet#16293 Context: dotnet@db74ff7 The `XamlC` task was failing to resolve public nested types from a class library. Fix this by updating the `IsPublicOrVisibleInternal` checks added in commit db74ff7 to also accept public nested types.
jonathanpeppers
approved these changes
Aug 18, 2023
Member
Author
|
@rmarinho looks like some known UI test issues may be blocking this? What is the best path forward to resolve this? |
Member
|
We can ignore the failing uitests. |
Member
Author
Thanks, do we need any other reviewers on this or could an owner override those check requirements and merge this? |
rmarinho
removed their request for review
August 21, 2023 14:58
rmarinho
approved these changes
Aug 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16293
Context: db74ff7
The
XamlCtask was failing to resolve public nested types from a classlibrary. Fix this by updating the
IsPublicOrVisibleInternalchecksadded in commit db74ff7 to also accept public nested types.