Repository navigation
Add interface to expose out UIView methods - #16868
Merged
Merged
Conversation
PureWeen
force-pushed
the
lifecycle_interface
branch
from
August 21, 2023 17:42
0acd35e to
701425d
Compare
mattleibow
reviewed
Aug 21, 2023
mattleibow
reviewed
Aug 22, 2023
mattleibow
reviewed
Aug 22, 2023
mattleibow
left a comment
mattleibow
left a comment
Member
There was a problem hiding this comment.
Seems valid and all that. Just had a Q on how the builds works when unloaded and how it can be used to detect unloaded. And I spotted a WillMoveToWindow calling MovedToWindow. Not sure if that should have been 2 events?
mattleibow
reviewed
Aug 22, 2023
mattleibow
previously approved these changes
Aug 23, 2023
rmarinho
requested changes
Aug 23, 2023
rmarinho
left a comment
rmarinho
left a comment
Member
There was a problem hiding this comment.
ExcludedWithChildren device test on iOS failing
rmarinho
reviewed
Aug 23, 2023
|
|
||
| // Because we can't inherit from Button we use the container to handle | ||
| // Life cycle events and things like monitoring focus changed | ||
| public override bool NeedsContainer => true; |
Member
There was a problem hiding this comment.
Isn't this a big change wrapping every button now on a UIView, border, shadows etc?!
Member
Author
There was a problem hiding this comment.
Ish? Containers in theory shouldn't be a big change. They should be mostly unnoticeable from a behavior stand point. This is iOS as well so not as worried about performance
rmarinho
reviewed
Aug 23, 2023
rmarinho
reviewed
Aug 23, 2023
rmarinho
approved these changes
Aug 24, 2023
jsuarezruiz
added
the
backport/suggested
PureWeen
added
the
backport/NO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Currently we're using KO's to monitor changes on iOS UIViews to trigger loaded/unloaded. This is very imprecise but also appears to cause occasional crashes. This PR begins the process of moving us to a more precise mechanism for monitoring when views are added/removed from the platform window.
Issues Fixed
Fixes #16860
Fixes #13245