Repository navigation
Update BindableObject API docs - #17099
Merged
Merged
Conversation
jknaudt21
reviewed
Aug 30, 2023
jknaudt21
left a comment
jknaudt21
left a comment
Contributor
There was a problem hiding this comment.
Small suggestions! Looks great overall
rmarinho
approved these changes
Aug 31, 2023
Member
|
Sorry pushed the button too early.. @jfversluis can you address the comments on a new PR please? thanks |
jfversluis
added
the
backport/suggested
Member
Author
|
Suggested backport since it should be relatively easy to do and help increase coverage also on .NET 7, also see #17138, that should be backported together with this. |
Member
|
/backport to net7.0 |
Contributor
|
Started backporting to net7.0: https://github.com/dotnet/maui/actions/runs/6098944644 |
Contributor
|
@mattleibow backporting to net7.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Update BindableObject API docs
Using index info to reconstruct a base tree...
M src/Controls/src/Core/BindableObject.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Controls/src/Core/BindableObject.cs
CONFLICT (content): Merge conflict in src/Controls/src/Core/BindableObject.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update BindableObject API docs
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
Contributor
|
@mattleibow an error occurred while backporting to net7.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Moves the external comments to inline, adds missing comments and minor improvements.
Issues Fixed
Related to #3960