Repository navigation
[net8.0] Add NuGet package information - #18197
Merged
Merged
Conversation
mattleibow
force-pushed
the
dev/nuget-info
branch
from
October 20, 2023 15:00
3e4966e to
bc68784
Compare
Eilon
suggested changes
Oct 20, 2023
Eilon
left a comment
Eilon
left a comment
Contributor
There was a problem hiding this comment.
This looks great. I read all the text for all the packages and the grammar/spelling is good, and this is all way better than before.
I added a note about the icon per your chat.
hartez
previously approved these changes
Oct 20, 2023
davidbritch
previously approved these changes
Oct 20, 2023
davidbritch
left a comment
davidbritch
left a comment
Contributor
There was a problem hiding this comment.
Approving because my feedback is real nit picking stuff.
One thing I noticed, and eventually stopped commenting on is application vs app. Some descriptions use app. Some use application. I've no preference. I just like consistency :)
Member
Author
|
@davidbritch I went with apps instead of applications as that is what all our concept docs say. |
Eilon
previously approved these changes
Oct 20, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Member
|
/rebase |
github-actions
Bot
force-pushed
the
dev/nuget-info
branch
from
October 23, 2023 10:57
32e1661 to
3dcd06c
Compare
mattleibow
force-pushed
the
dev/nuget-info
branch
from
October 23, 2023 13:57
3dcd06c to
ed9db2d
Compare
mattleibow
changed the title
mattleibow
force-pushed
the
dev/nuget-info
branch
from
October 23, 2023 15:06
ed9db2d to
4d46571
Compare
Member
Author
|
|
Eilon
approved these changes
Oct 23, 2023
rmarinho
approved these changes
Oct 23, 2023
Member
|
/backport to release/8.0.1xx-rc2 |
Contributor
|
Started backporting to release/8.0.1xx-rc2: https://github.com/dotnet/maui/actions/runs/6628441519 |
Contributor
|
@PureWeen backporting to release/8.0.1xx-rc2 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Add NuGet package information
Using index info to reconstruct a base tree...
M Directory.Build.props
M Directory.Build.targets
M src/Essentials/src/Essentials.csproj
M src/Graphics/src/Graphics.Skia/Graphics.Skia.csproj
M src/Graphics/src/Graphics.Win2D/Graphics.Win2D.csproj
M src/Graphics/src/Graphics/Graphics.csproj
Falling back to patching base and 3-way merge...
Auto-merging src/Graphics/src/Graphics/Graphics.csproj
CONFLICT (content): Merge conflict in src/Graphics/src/Graphics/Graphics.csproj
Auto-merging src/Graphics/src/Graphics.Win2D/Graphics.Win2D.csproj
Auto-merging src/Graphics/src/Graphics.Skia/Graphics.Skia.csproj
Auto-merging src/Essentials/src/Essentials.csproj
Auto-merging Directory.Build.targets
Auto-merging Directory.Build.props
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add NuGet package information
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
Contributor
|
@PureWeen an error occurred while backporting to release/8.0.1xx-rc2, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Add more detailed and correct information into the packages. Also make sure they all have icons.