⭐ Football Update: dotnet/maui/pull/

praveenkumarkarunanithi · 2026-06-23T05:48:34Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue.
Thank you!

Root Cause

When NavigationPage.HasNavigationBar is set to false, ToolbarExtensions.UpdateIsVisible collapses the toolbar height to 0. However, the AppBarLayout parent retains stale top padding from a previous inset dispatch — for example, 159px from the status bar/cutout.

Even with toolbar height 0, AppBarLayout.MeasuredHeight remains at 159px because it is driven by padding alone. MauiWindowInsetListener checks MeasuredHeight > 0 to determine whether the AppBar has content. Since it sees 159 > 0, it treats the AppBar as having content, consumes the top system inset, and the inset never reaches SafeAreaExtensions downstream.

The result is a blank gap at the top of the screen equal to the status bar height — visible on both NavigationPage (when a page is pushed with the nav bar hidden) and Shell (when the navigation bar is hidden at runtime).

Description of Change

A single line is added to ToolbarExtensions.UpdateIsVisible in the !showNavBar branch to call SetPadding(0, 0, 0, 0) on the AppBarLayout.

This clears the stale padding so MeasuredHeight collapses to 0. The inset listener then correctly identifies the AppBar as having no content, passes the top inset downstream, and SafeAreaEdges=None is fully respected with no blank gap.

The re-show path is safe — RequestApplyInsets is called in both branches of UpdateIsVisible, so the next inset dispatch naturally restores the correct padding when the nav bar is shown again.

Parent traversal uses nativeToolbar.Parent?.GetParentOfType<AppBarLayout>() — the established MAUI pattern used in ShellToolbarTracker.cs.

Two new device tests pin the fix for both affected paths:

PushingToPageWithoutNavigationBarClearsAppBarInsetPadding for the NavigationPage scenario
HiddenShellNavigationBarClearsAppBarInsetPadding for the Shell scenario
These tests were adopted from open contributor PR Fix Android Shell top inset when nav bar is hidden #35555 .

Issues Fixed

Fixes #35103
Fixes #34472

Tested the behaviour in the following platforms

Android
Windows
iOS
Mac

Screenshots

Before Issue Fix	After Issue Fix
WithoutFix.mov	WithFix.mov

github-actions · 2026-06-23T05:48:42Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 36072

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 36072"

vishnumenon2684 · 2026-06-23T07:45:17Z

/azp run

azure-pipelines · 2026-06-23T07:45:41Z

Azure Pipelines successfully started running 3 pipeline(s).

Validating /review tests on open PR #36072 surfaced a false-positive deterministic regression: the Android SDK 'platform-tools;35.0.2' provisioning flake ('Failed to find package') was labeled regressed-vs-base, inflating the regression count 9->7 and over-claiming PR causation on a purely environmental failure. Root cause: legRegressedVsBase latched across occurrences. The same failure sprayed onto two legs of the PR build -- one flaky on base (failed attempt 1, passed on retry => inconclusive-on-base) and one cleanly green on base. The clean-green leg latched legRegressed=true while the inconclusive-conflict signal from the other leg was dropped. Two layered guards, both FALSE-RED reductions only (a demoted failure falls to 'indeterminate'/NHI and can never become a false green): 1. Provisioning/infra signature guard: failures matching Android SDK package-fetch / avdmanager / disk-full signatures are environmental and nondeterministic, so they never set legRegressed. 2. Cross-leg conflict veto: if a failure regressed cleanly in one leg but was flaky (inconclusive) on base in another leg, suppress the clean-regression claim. Verified on #36072: 9->7 regressions (2 platform-tools demoted to indeterminate), verdict correctly stays 'Not ready' on the 7 genuine green-on-base/red-on-PR UI-test legs. Harness 167->178 assertions, green. SKILL.md attribution contract updated (inconclusive-on-base + the computed infra/flaky exclusions). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…es (demote+enrich only) The deterministic leg diff compares each PR leg to the ONE most recent completed base build, so a test that is flaky/regressed on the base BRANCH but happened to be green on that single build shows up as a false 'regressed-vs-base'. This is the single-base-build limitation called out when validating /review tests on open PRs. The repo already maintains a richer signal: the open '[ci-scan]' issues produced by the CI Failure Scanner (ci-status-* agentic workflow), which track recurring flakes, regressions, and build breaks on the main / net11.0 base branches across MANY builds, with explicit branch, affected legs, occurrence counts, and error signatures. The gatherer did not consult them. Wire ci-scan in as a DEMOTE + ENRICH signal only (never dismiss-to-green): - Get-CiScanIssues parses each open ci-scan issue into a matcher: branch family, class (recurring/regression/build-break), the set of test-name tokens it documents, affected-leg tokens, occurrence text, and a legScoped flag (whole-leg instability vs a single named test). - Test-CiScanMatch matches a failure by exact leaf test-name (precise) or, for legScoped issues only (OneTimeSetUp/mass/env/build-break), by affected-leg overlap. Branch family must match -- a main PR is never demoted by a net11.0 issue, and vice versa. - When the leg diff computed a clean single-base 'regressed-vs-base' AND ci-scan documents that exact test/leg failing on the base branch, the regression is demoted to 'indeterminate' (NHI) with ciScanDemoted=true. This is a false-RED reduction ONLY: a demoted failure still forbids a green verdict (ceiling stays >= NHI), so a ci-scan hit -- an LLM-generated, possibly-stale hint -- can never turn a red check green; it can only move an over-confident 'Not ready' down to 'needs a human'. The legScoped gate stops a single-test issue's incidental leg from over-demoting unrelated tests on a busy leg. Validated live on #36072: 4 Android API-30 regressions on the OneTimeSetUp- flaky leg (documented by #35958, 2+/10 builds on main) demoted to NHI; the 3 genuine off-leg regressions (DragAndDrop/Alerts/AcceptedOperationNone...) preserved; verdict correctly stays 'Not ready'. Unit harness: 23 matcher assertions (branch gate, exact-token, legScoped) + 13 in the main harness (now 191), all green. SKILL.md contract updated. Gatherer + SKILL.md are referenced by path (not inlined in the lock), so no workflow recompile. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

vishnumenon2684 · 2026-06-25T10:56:02Z

/azp run maui-pr-uitests , maui-pr-devicetests

azure-pipelines · 2026-06-25T10:56:16Z

Azure Pipelines successfully started running 2 pipeline(s).

Copilot

Pull request overview

Fixes an Android edge-to-edge inset regression where hiding the navigation bar (HasNavigationBar=false / Shell.NavBarIsVisible=false) could leave stale AppBarLayout padding, causing the top system inset to be incorrectly consumed and resulting in a blank gap when SafeAreaEdges=None.

Changes:

Clear stale AppBarLayout padding when the Android toolbar is hidden so MauiWindowInsetListener no longer treats the app bar as “having content”.
Add Android UI test coverage for the NavigationPage push scenario tied to issue #34472.
Add Android device tests (Shell + NavigationPage) and shared helpers to validate inset consumption behavior with synthetic top insets.

Reviewed changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/Controls/src/Core/Platform/Android/Extensions/ToolbarExtensions.cs	Clears `AppBarLayout` padding when hiding the toolbar to prevent top inset being consumed by stale padding.
src/Controls/tests/DeviceTests/ControlsHandlerTestBase.Android.cs	Adds reusable helpers to create synthetic insets and capture applied insets during device tests.
src/Controls/tests/DeviceTests/Elements/NavigationPage/NavigationPageTests.Android.cs	Adds a device regression test asserting app bar padding clears and top insets pass through when pushing a page with nav bar hidden.
src/Controls/tests/DeviceTests/Elements/Shell/ShellTests.Android.cs	Adds a device regression test asserting app bar padding clears and top insets pass through when Shell nav bar is hidden.
src/Controls/tests/TestCases.HostApp/Issues/Issue34472.cs	Adds a HostApp repro page for the NavigationPage SafeAreaEdges regression on Android.
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue34472.cs	Adds an Android UI test validating consistent top positioning between pushed vs. main-page scenarios.

MauiBot

AI Review Summary

@praveenkumarkarunanithi — new AI review results are available based on this last commit: 15124a4. To request a fresh review after new comments or commits, comment /review rerun.

🗂️ Review Sessions — click to expand

🚦 Gate — Test Before & After Fix