Skip to content

Support new GAV of plexus-build-apiΒ #944

Open

Description

@laeubi

Activity

  1. HannesWell commented on Sep 27, 2022

    @HannesWell
    Contributor

    See codehaus-plexus/plexus-build-api@9c2e013

    codehaus-plexus/plexus-build-api#21

    We could simply have both APIs supported.

    The dependency can be added/changed here (just in case you didn't already know :) ):

    <groupId>org.sonatype.plexus</groupId>

    If the fully-qualified names did not change we have to or can use that as drop in replacement.

  2. added
    usabilityImprovements that can give a better usability or user experience
    on Dec 16, 2022
  3. self-assigned this
    on Mar 9, 2023
  4. kwin commented on May 22, 2023

    @kwin
    Member

    @laeubi Is something still missing in master...laeubi:m2e-core:issue_944_new_plexus_api or can we include this in the upcoming release?

  5. laeubi commented on May 22, 2023

    @laeubi
    MemberAuthor

    It is at least missing that I need to finish/finalize that :-)

  6. laeubi commented on May 26, 2023

    @laeubi
    MemberAuthor

    @gnodet @kwin if you like to speed this up, the most critical part (for me) currently is that we do not have good test-coverage but high impact if we break things.
    So if we can have some test in https://github.com/eclipse-m2e/m2e-core/tree/master/org.eclipse.m2e.core.tests that cover the functionality this would help a lot, I already tried before getting an integration-test with a dummy-maven plugin but can't get it reliable working that a plugin compiled in the current reactor is used in a test.

  7. gnodet commented on May 26, 2023

    @gnodet

    @laeubi the branch does not build anymore from the command line.
    I end up with

    [ERROR] Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:4.0.0-SNAPSHOT:compare-version-with-baselines (check-no-version-regression) on project org.eclipse.m2e.model.edit: Version have moved backwards for (org.eclipse.m2e.model.edit/2.0.200.20230130-0743). Baseline has 2.0.300.20230320-2130) with delta: 0.0.-100 -> [Help 1]
    org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:4.0.0-SNAPSHOT:compare-version-with-baselines (check-no-version-regression) on project org.eclipse.m2e.model.edit: Version have moved backwards for (org.eclipse.m2e.model.edit/2.0.200.20230130-0743). Baseline has 2.0.300.20230320-2130) with delta: 0.0.-100
    

    but there's no references to either version in the source tree.

  8. gnodet commented on May 26, 2023

    @gnodet

    Also and fwiw, the project does not load correctly in IntelliJ (all the Tyco projects are not recognised) nor Eclipse Java (class path does not seem to be initialised correctly).

    I've done quite a lof to OSGi development in the past, but not using Tycho, Eclipse or M2e, so I'm not familiar with the whole setup.

  9. laeubi commented on May 26, 2023

    @laeubi
    MemberAuthor

    M2E is an eclipse project so Eclipse IDE is somehow a requirement (even though it might work to some degree with IntelliJ).

    You can setup a Dev-IDE here:
    https://github.com/eclipse-m2e/m2e-core/blob/master/CONTRIBUTING.md#%EF%B8%8F-setting-up-the-development-environment-automatically-using-the-eclipse-installer-oomph

    Regarding the branch, the best would be to just start from the master and as a first step add a test-case before try to apply any of the changes this can then be merged already as a prerequisite and will show that the dev-workflow works already.

    If we have this I can rebase my branch ontop of this to see if it already breaks something, and add support for the new GAV.

  10. mickaelistria commented on Jun 18, 2025

    @mickaelistria
    Contributor

    In the meantime, plexus-build-api also changed its package names. We'll most likely need to deal with both variants of BuildContext in m2e code (and warn when older one is being used).

  11. laeubi commented on Jun 18, 2025

    @laeubi
    MemberAuthor

    It should actually already work as there is a redirect from one API to the other.
    @mickaelistria du you face any specific problem here?

  12. mickaelistria commented on Jun 18, 2025

    @mickaelistria
    Contributor

    du you face any specific problem here?

    Not really, I just stumbled upon some related discussions that are still open as Maven moves some tracking to GitHub issues ( apache/maven-assembly-plugin#1150 ). Note that the "how to make Maven plugin m2e-friendly" doc still mentions the sonatype variant of BuildContext. Should it be updated to use the plexus one?

  13. laeubi commented on Jun 18, 2025

    @laeubi
    MemberAuthor

    Should it be updated to use the plexus one?

    Sounds reasonable.

  14. kwin commented on Sep 12, 2025

    @kwin
    Member

    @laeubi Can you close this issue then, indicating which m2e version contains the fix?

  15. wilx commented on Aug 1, 2026

    @wilx

    What is the status of the compatibility for the Plexus API classes vs the old Sonatype API classes in the m2e? Can this be closed because eclipse-sisu/sisu-project#215 was merged?

  16. laeubi commented on Aug 2, 2026

    @laeubi
    MemberAuthor

    I'm not sure what sisu has to do with it but the new plexus-api does contain a compatibility layer and therfore m2e can use the old+new API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

sponsoredusabilityImprovements that can give a better usability or user experience

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions