Repository navigation
Conversation
Contributor
|
thomasbierly
force-pushed
the
fix/per-monitor-window-manager-settings
branch
from
September 20, 2026 11:12
1c1ee7a to
9b86b1c
Compare
The window manager reads its config straight from the global map:
settingsInit.byWidget["@seelen/window-manager"]
so any override stored in monitorsV3[id].byWidget for that widget is
silently ignored. Setting workspaceMargin per monitor has no effect;
only the global value applies, which forces the same reservation onto
every monitor.
Settings.getCurrentWidgetConfig() already merges defaults, global,
instance and monitor layers, and flyouts and task-switcher both use it.
The same file already honours per-monitor `enabled` for the toolbar and
weg when computing the tiling rect, so per-monitor awareness looks
intended here rather than deliberately omitted.
Switch to that accessor for both the initial read and the onChange
handler.
Motivating case: a third-party widget docked to one monitor's edge as an
AppBar. The tiler doesn't use the Windows work area, so a per-monitor
workspaceMargin is the way to keep tiled windows clear of it -- but it
has to be applied globally today, costing that width on every screen.
thomasbierly
force-pushed
the
fix/per-monitor-window-manager-settings
branch
from
September 20, 2026 11:20
9b86b1c to
1c9dded
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The window manager reads its config straight from the global map:
so any override stored in monitorsV3[id].byWidget for that widget is silently ignored. Setting workspaceMargin per monitor has no effect; only the global value applies, which forces the same reservation onto every monitor.
Settings.getCurrentWidgetConfig() already merges defaults, global, instance and monitor layers, and flyouts and task-switcher both use it. The same file already honours per-monitor
enabledfor the toolbar and weg when computing the tiling rect, so per-monitor awareness looks intended here rather than deliberately omitted.Switch to that accessor for both the initial read and the onChange handler.
Motivating case: a third-party widget docked to one monitor's edge as an AppBar. The tiler doesn't use the Windows work area, so a per-monitor workspaceMargin is the way to keep tiled windows clear of it -- but it has to be applied globally today, costing that width on every screen.