Repository navigation
和AI（workbuddy）修复了我之前汇报的#1669错误 - #1839
Merged
eythaann merged 4 commits intoSep 22, 2026
Merged
Conversation
`ToastNotificationManagerForUser::NotificationModeChanged` and `NotificationMode` are only implemented on Windows 11. On Windows 10 both fail with E_NOINTERFACE (0x80004002), verified on build 19042.546. That caused two separate failures, both surfacing to the user as "notifications never show up": - `NotificationManager::init` propagated the error with `?`, which skipped the `subscribe` right below it. The change listener (or its polling fallback) still emitted Added/Removed events but nothing handled them, so the notification list stayed frozen on its initial snapshot. - `get_notifications_mode` returned an error, and the frontend awaits that command at module top level. The rejection aborted the state module, so neither the notifications widget nor the flyouts widget ever mounted. Both call sites now treat the mode API as optional: - `init` logs a warning and continues, so the event handler is always registered. - `get_notifications_mode` falls back to `NotificationsMode::All`, and both frontend runes do the same if the command still fails. The do not disturb toggle is therefore simply inactive on systems without the API, instead of breaking notifications as a whole.
Contributor
 |
This reverts commit 5d454fd.
Restores src/ui/svelte/flyouts/state/mod.svelte.ts and src/ui/svelte/notifications/state.svelte.ts to their pre-fix state.
eythaann
self-requested a review
September 22, 2026 11:21
eythaann
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1669