Repository navigation
fix(flutter): Use static SwiftPM binaries - #4118
Merged
Merged
Conversation
Contributor
Semver Impact of This PRπ’ Patch (bug fixes) π Changelog PreviewThis is how your changes will appear in the changelog. Fixes
Internal Changes
π€ This preview updates automatically when you update the PR. |
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4118 +/- ##
==========================================
+ Coverage 88.78% 92.94% +4.15%
==========================================
Files 348 114 -234
Lines 12631 4636 -7995
==========================================
- Hits 11215 4309 -6906
+ Misses 1416 327 -1089
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Harness. |
philprime
marked this pull request as ready for review
October 26, 2026 20:05
Collaborator
|
Q: This change also applies to Sentry React Native, Capacitor and other platforms? |
Collaborator
|
after a quick check, capacitor also suffers from this issue, will replicate the PR there later |
4 of 11 tasks
This was referenced Oct 29, 2026
lucas-zimerman
added a commit
to getsentry/sentry-capacitor
that referenced
this pull request
Oct 29, 2026
* fix(ios): Use static SwiftPM binaries Use the Sentry-Static product from sentry-apple-binaries for SwiftPM builds, avoiding downloads of the unused dynamic and platform variants in the full sentry-cocoa package. The pinned Cocoa version stays 9.28.0. Update the version regex in update-cocoa.sh for the mirror URL and align the example apps' Package.resolved files. Release discovery remains on sentry-cocoa, where GitHub releases are published. Port of getsentry/sentry-dart#4118. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: Link changelog entry to PR Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
philprime
added a commit
to getsentry/sentry-cocoa
that referenced
this pull request
Oct 30, 2026
sentry-dart now depends on the Sentry-Static product of sentry-apple-binaries instead of the Sentry product of sentry-cocoa (getsentry/sentry-dart#4118), so the Package.swift replacement no longer matched. Map both packages and the product to the local checkout and fail if any remote reference remains. Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Phil Niedertscheider <30923007+philprime@users.noreply.github.com>
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use the
Sentry-Staticproduct fromsentry-apple-binariesfor SwiftPM builds, avoiding the unused dynamic and platform variants in the full Cocoa package. The pinned Cocoa version remains 9.31.0, with the same static framework URL, checksum, and C++ helper.Update version parsing and replacement for the mirror URL, and align the example app's SwiftPM lockfiles with the mirror. Release discovery remains on
sentry-cocoa, where GitHub releases are published.Motivation and Context
Fixes #4117.
SwiftPM downloads binary targets beyond the selected product. The mirror contains two static binary targets instead of the full package's seven, reducing clean-build downloads and exposure to download failures.
How did you test it?
git diff --check.CI passes iOS/macOS native and integration tests, iOS/Android size-analysis builds, and minimum-version builds.
Checklist
sendDefaultPiiis enabled