Repository navigation
fix(aws-serverless): Omit default port from url.full on function.aws spans - #26227
Merged
Merged
Conversation
β¦spans url.full on Lambda HTTP invocations always carried x-forwarded-port, so every Function URL / API Gateway request read https://host:443/path. Drop 80/443 for their scheme like browsers do, and don't append the port when the host header already has one (ALB on a custom port produced host:8080:8080). Co-Authored-By: Francesco Gringl-Novy <francesco.novy@sentry.io>
Contributor
size-limit report π¦Compared: 27c6473 (PR test merge using develop at 1d354fd) Against: 1d354fd (develop) Β· base run #65483 β Baseline matches: this diff contains only this PR's changes.
|
andreiborza
approved these changes
Nov 10, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
β Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit babe47c. Configure here.
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 8 not successful, 49 successful. See the run.
Successful checks
|
51 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why:
url.fullon HTTP-triggered Lambda invocations always appendedx-forwarded-port, so every Function URL and API Gateway request readhttps://host:443/path. We now drop 80/443 for their scheme, like browsers do. We also don't append the port when the host header already has one: an ALB on a custom port producedhost:8080:8080.How to review: Small change in
extractFullUrlplus unit tests. The value ofurl.fullchanges for existing users, but the attribute itself stays.Refs #25813
via Francesco Gringl-Novy.
--
View Session [Sentry]