Skip to content

fix(aws-serverless): Omit default port from url.full on function.aws spans - #26227

Merged
mydea merged 2 commits into
developfrom
fix/aws-serverless-url-default-port
Nov 10, 2026
Merged

mydea merged 2 commits into
developfrom
fix/aws-serverless-url-default-port

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Why: url.full on HTTP-triggered Lambda invocations always appended x-forwarded-port, so every Function URL and API Gateway request read https://host:443/path. We now drop 80/443 for their scheme, like browsers do. We also don't append the port when the host header already has one: an ALB on a custom port produced host:8080:8080.

How to review: Small change in extractFullUrl plus unit tests. The value of url.full changes for existing users, but the attribute itself stays.

Refs #25813

via Francesco Gringl-Novy.

--

View Session [Sentry]

…spans

url.full on Lambda HTTP invocations always carried x-forwarded-port, so
every Function URL / API Gateway request read https://host:443/path.
Drop 80/443 for their scheme like browsers do, and don't append the port
when the host header already has one (ALB on a custom port produced
host:8080:8080).

Co-Authored-By: Francesco Gringl-Novy <francesco.novy@sentry.io>
@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

size-limit report πŸ“¦

Compared: 27c6473 (PR test merge using develop at 1d354fd)

Against: 1d354fd (develop) Β· base run #65483

βœ… Baseline matches: this diff contains only this PR's changes.

Path Size % Change Change
@sentry/browser 29.92 kB - -
@sentry/browser - with treeshaking flags 28.08 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 27.97 kB - -
@sentry/browser (incl. Tracing) 52.29 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 52.3 kB - -
@sentry/browser (incl. Tracing, Profiling) 55.27 kB - -
@sentry/browser (incl. Tracing, Replay) 92.61 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 81.29 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 97.34 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 110.34 kB - -
@sentry/browser (incl. Feedback) 47.52 kB - -
@sentry/browser (incl. sendFeedback) 35.02 kB - -
@sentry/browser (incl. FeedbackAsync) 40.13 kB - -
@sentry/browser (incl. Metrics) 31.48 kB - -
@sentry/browser (incl. Logs) 31.77 kB - -
@sentry/browser (incl. Metrics & Logs) 32.45 kB - -
@sentry/react 31.78 kB - -
@sentry/react (incl. Tracing) 54.76 kB - -
@sentry/vue 38.33 kB - -
@sentry/vue (incl. Tracing) 55.33 kB - -
@sentry/svelte 29.95 kB - -
@sentry/remix (Remix 3 client bundle) 57.92 kB - -
CDN Bundle 31.72 kB - -
CDN Bundle (incl. Tracing) 52.89 kB - -
CDN Bundle (incl. Logs, Metrics) 34.52 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 55.39 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 75.9 kB - -
CDN Bundle (incl. Tracing, Replay) 91.06 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 93.62 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 97.19 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 99.8 kB - -
CDN Bundle - uncompressed 92.76 kB - -
CDN Bundle (incl. Tracing) - uncompressed 156.02 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 101.29 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 163.79 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 232.85 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 277.71 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 285.47 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 291.41 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 299.17 kB - -
@sentry/nextjs (client) 57.73 kB - -
@sentry/sveltekit (client) 52.82 kB - -
@sentry/core/server 44.29 kB - -
@sentry/core/browser 14.02 kB - -
@sentry/node 157.13 kB +0.02% +19 B πŸ”Ί
@sentry/node/import (ESM hook with diagnostics-channel injection) 82.28 kB - -
@sentry/node - without tracing 96.91 kB +0.03% +21 B πŸ”Ί
@sentry/node - without channel injection 137.41 kB +0.02% +21 B πŸ”Ί
@sentry/aws-serverless 105.58 kB +0.03% +22 B πŸ”Ί
@sentry/cloudflare (withSentry) - minified 203.34 kB - -
@sentry/cloudflare (withSentry) 505.12 kB - -
@sentry/nextjs/cloudflare (withSentry) - minified 225.19 kB - -

View base workflow run

@mydea
mydea marked this pull request as ready for review November 10, 2026 10:47
@mydea
mydea requested review from a team, JPeer264 and stephanie-anderson November 10, 2026 10:47
@mydea
mydea requested a review from a team as a code owner November 10, 2026 10:47
@mydea
mydea requested review from andreiborza and removed request for a team November 10, 2026 10:47

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit babe47c. Configure here.

@mydea
mydea enabled auto-merge (squash) November 10, 2026 10:53
@mydea
mydea merged commit 4c4b235 into develop Nov 10, 2026
428 of 436 checks passed
@mydea
mydea deleted the fix/aws-serverless-url-default-port branch November 10, 2026 11:01
@github-actions

Copy link
Copy Markdown
Contributor

Optional E2E tests

Some optional checks were not successful. They do not block the merge. 8 not successful, 49 successful. See the run.

Check Status
❌ CI: Optional E2E Tests / E2E cloudflare-pi-durable Test (optional) Failing after 30s Details
❌ CI: Optional E2E Tests / E2E nextjs-16-cacheComponents (cloudflare) Test (optional) Failing after 10m Details
❌ CI: Optional E2E Tests / E2E node-eve Test (optional) Failing after 2m Details
❌ CI: Optional E2E Tests / E2E cloudflare-pi-durable (latest) Test (optional) Failing after 29s Details
❌ CI: Optional E2E Tests / E2E node-flue (latest) Test (optional) Failing after 25s Details
❌ CI: Optional E2E Tests / E2E node-eve (latest) Test (optional) Failing after 1m Details
❌ CI: Optional E2E Tests / E2E node-eve (orchestrion) Test (optional) Failing after 2m Details
❌ CI: Optional E2E Tests / E2E solidstart-2 Test (optional) Failing after 50s Details
Successful checks
Check Status
βœ… CI: Optional E2E Tests / E2E cloudflare-think Test (optional) Successful in 57s Details
βœ… CI: Optional E2E Tests / E2E debug-id-sourcemaps Test (optional) Successful in 39s Details
βœ… CI: Optional E2E Tests / E2E nextjs-16 (deno) Test (optional) Successful in 2m Details
βœ… CI: Optional E2E Tests / E2E cloudflare-workers-send-to-sentry Test (optional) Successful in 2m Details
βœ… CI: Optional E2E Tests / E2E nextjs-orpc Test (optional) Successful in 1m Details
βœ… CI: Optional E2E Tests / E2E node-mastra Test (optional) Successful in 1m Details
βœ… CI: Optional E2E Tests / E2E cloudflare-flue-send-to-sentry Test (optional) Successful in 2m Details
βœ… CI: Optional E2E Tests / E2E cloudflare-agent Test (optional) Successful in 48s Details
βœ… CI: Optional E2E Tests / E2E node-express-mcp-v2 Test (optional) Successful in 36s Details
βœ… CI: Optional E2E Tests / E2E cloudflare-think (ai v6) Test (optional) Successful in 1m Details
βœ… CI: Optional E2E Tests / E2E gen-ai-libraries (latest) Test (optional) Successful in 57s Details
βœ… CI: Optional E2E Tests / E2E astro-7-static Test (optional) Successful in 1m Details
βœ… CI: Optional E2E Tests / E2E nextjs-15 (latest) Test (optional) Successful in 4m Details
βœ… CI: Optional E2E Tests / E2E astro-7 Test (optional) Successful in 1m Details
βœ… CI: Optional E2E Tests / E2E nextjs-16 (cloudflare, latest) Test (optional) Successful in 2m Details
βœ… CI: Optional E2E Tests / E2E nextjs-14 (latest) Test (optional) Successful in 2m Details
βœ… CI: Optional E2E Tests / E2E node-express-send-to-sentry-static Test (optional) Successful in 1m Details
βœ… CI: Optional E2E Tests / E2E node-express-mcp-v1 Test (optional) Successful in 33s Details
βœ… CI: Optional E2E Tests / E2E nextjs-16-tunnel (cloudflare) Test (optional) Successful in 1m Details
βœ… CI: Optional E2E Tests / E2E node-openai-decisions Test (optional) Successful in 29s Details
βœ… CI: Optional E2E Tests / E2E nextjs-16 (vinext) Test (optional) Successful in 1m Details
βœ… CI: Optional E2E Tests / E2E nuxt-5 Test (optional) Successful in 2m Details
βœ… CI: Optional E2E Tests / E2E nuxt-5 (tunnel-dev) Test (optional) Successful in 56s Details
βœ… CI: Optional E2E Tests / E2E nextjs-15 (turbo) Test (optional) Successful in 2m Details
βœ… CI: Optional E2E Tests / E2E deno (latest) Test (optional) Successful in 1m Details
βœ… CI: Optional E2E Tests / E2E nestjs-12 (latest) Test (optional) Successful in 55s Details
βœ… CI: Optional E2E Tests / E2E nextjs-16 (vinext, bun) Test (optional) Successful in 1m Details
βœ… CI: Optional E2E Tests / E2E gen-ai-libraries Test (optional) Successful in 46s Details
βœ… CI: Optional E2E Tests / E2E node-openai-decisions (latest) Test (optional) Successful in 28s Details
βœ… CI: Optional E2E Tests / E2E node-express-send-to-sentry Test (optional) Successful in 1m Details
βœ… CI: Optional E2E Tests / E2E node-flue Test (optional) Successful in 2m Details
βœ… CI: Optional E2E Tests / E2E gen-ai-libraries (cloudflare) Test (optional) Successful in 44s Details
βœ… CI: Optional E2E Tests / E2E react-send-to-sentry Test (optional) Successful in 3m Details
βœ… CI: Optional E2E Tests / E2E node-pi-durable Test (optional) Successful in 39s Details
βœ… CI: Optional E2E Tests / E2E node-fastify-6 (tracer provider) Test (optional) Successful in 37s Details
βœ… CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (static / nuxt generate) Test (optional) Successful in 42s Details
βœ… CI: Optional E2E Tests / E2E node-fastify-6 Test (optional) Successful in 37s Details
βœ… CI: Optional E2E Tests / E2E supabase-nextjs Test (optional) Successful in 2m Details
βœ… CI: Optional E2E Tests / E2E node-mastra (latest) Test (optional) Successful in 1m Details
βœ… CI: Optional E2E Tests / E2E nuxt-5-cloudflare Test (optional) Successful in 35s Details
βœ… CI: Optional E2E Tests / E2E react-router-7-framework-instrumentation Test (optional) Successful in 2m Details
βœ… CI: Optional E2E Tests / E2E tanstackstart-react (latest) Test (optional) Successful in 1m Details
βœ… CI: Optional E2E Tests / E2E tanstackstart-react-cloudflare Test (optional) Successful in 44s Details
βœ… CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (client source maps kept) Test (optional) Successful in 40s Details
βœ… CI: Optional E2E Tests / E2E tanstackstart-react-sourcemaps Test (optional) Successful in 37s Details
βœ… CI: Optional E2E Tests / E2E vue-3 (no Options API) Test (optional) Successful in 1m Details
βœ… CI: Optional E2E Tests / E2E node-pi-durable (latest) Test (optional) Successful in 36s Details
βœ… CI: Optional E2E Tests / E2E cloudflare-mastra Test (optional) Successful in 43s Details
βœ… CI: Optional E2E Tests / E2E nuxt-5-sourcemaps Test (optional) Successful in 40s Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants