Repository navigation
fix(solidstart): Keep build-time tooling out of SolidStart 2 server bundles - #26277
Merged
Merged
Conversation
β¦undles The root server entry still re-exports the deprecated SolidStart 1 `withSentry`, which pulls `@sentry/bundler-plugins` and with it the Sentry CLI and oxc-parser into the Nitro server graph. Since the CLI bump to 0.49 (code-split ESM with dynamic imports), Rolldown emits the CLI's chunks even after tree-shaking the code that imports them, and Nitro traces oxc-parser's native binding. `sentrySolidStart()` now adds a `sentry-solidstart-runtime` export condition to server environments, which resolves `@sentry/solidstart` to the server entry without `withSentry`. Co-Authored-By: Francesco Gringl-Novy <francesco.novy@sentry.io>
Contributor
Optional E2E testsAll optional checks were successful. 1 successful. See the run. Successful checks
|
Contributor
size-limit report π¦Compared: 9cc81f6 (PR test merge using develop at 15f3d8d) Against: 15f3d8d (develop) Β· base run #65640 β Baseline matches: this diff contains only this PR's changes.
|
mydea
marked this pull request as ready for review
November 11, 2026 10:35
mydea
requested review from
chargome and
s1gr1d
and removed request for
a team
November 11, 2026 10:36
andreiborza
approved these changes
Nov 11, 2026
51 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: The
solidstart-2e2e test has been failing ondevelopsince #26200 bumped the Sentry CLI to^0.49.0. The server entry of@sentry/solidstartstill re-exports the deprecated SolidStart 1withSentry. That pulls@sentry/bundler-plugins, and with it the CLI andoxc-parser, into the Nitro server graph. Starting with 0.48, the CLI ships as code-split ESM. Rolldown still emits its dynamic-import chunks after tree-shaking the code that imports them; Rollup doesn't. Nitro also tracesoxc-parser's native binding. For every SolidStart 2 app, the result is about 3.6 MB of unused build tooling in.output/server(5.3 MB β 1.7 MB with this change). The CLI chunk also carries the CLI's own debug IDs, which the app can't upload, and that's the assertion that fails.Removing the root
withSentryexport is breaking (#25915, v12), and lazy imports are off the table. SosentrySolidStart()now adds asentry-solidstart-runtimeexport condition to server environments. The exports map resolves that condition to the existing server entry, which is the same as today's minuswithSentry. SolidStart 1'sapp.config.tsnever sets the condition, so it still getswithSentry.How to review: Start with the
exportschange inpackage.json, thenmakeServerEntryPlugin. Locally,solidstart-2(including the tunnel-basepath dev variant) andsolidstartpass against CI tarballs.Unsure about: Whether a custom export condition is the shape we want here, versus living with the bloat until v12. The plugin only extends conditions that are already set, because Vite would otherwise replace its defaults. Nitro and SolidStart always set them for their server environments. Separately, the Rolldown behaviour seems worth an upstream issue.
via Francesco Gringl-Novy.
--
View Session [Sentry]