Repository navigation
test(nuxt): Add vue-router to Nuxt 5 E2E apps - #26323
Merged
Merged
Conversation
Nuxt 5 nightlies moved vue-router from a dependency to an optional peer dependency, so apps with a pages/ directory fail to build without it. Co-Authored-By: Francesco Gringl-Novy <2411343+mydea@users.noreply.github.com>
Contributor
size-limit report π¦Compared: 26ffa45 (PR test merge using develop at 359fbe4) Against: 359fbe4 (develop) Β· base run #65839 β Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsAll optional checks were successful. 5 successful. See the run. Successful checks
|
mydea
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Nuxt 5 nightlies from
5.0.0-2611121215on movedvue-routerfromdependenciesto an optional peer dependency. Apps with apages/directory now failnuxt buildwithCannot find package 'vue-router'. That breaks the requiredE2E nuxt-5 (tunnel-basepath)check, and with it every PR intodevelop, plus the optionalnuxt-5andnuxt-5-sourcemapsvariants.nuxt-5-cloudflarehas no pages, so it still builds and is left unchanged.How to review: I reproduced the failure in a minimal pages app on
nuxt-nightly@5.0.0-2611121224-0568af6. Addingvue-router@^5.5.0makes it build again. Older nightlies already shippedvue-router@^5.5.0as a dependency, so this range matches them too.via @mydea.
--
View Session [Sentry]