Skip to content

test(nuxt): Add vue-router to Nuxt 5 E2E apps - #26323

Merged
mydea merged 1 commit into
developfrom
fix/e2e-nuxt-5-vue-router
Nov 12, 2026
Merged

mydea merged 1 commit into
developfrom
fix/e2e-nuxt-5-vue-router

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Why: Nuxt 5 nightlies from 5.0.0-2611121215 on moved vue-router from dependencies to an optional peer dependency. Apps with a pages/ directory now fail nuxt build with Cannot find package 'vue-router'. That breaks the required E2E nuxt-5 (tunnel-basepath) check, and with it every PR into develop, plus the optional nuxt-5 and nuxt-5-sourcemaps variants. nuxt-5-cloudflare has no pages, so it still builds and is left unchanged.

How to review: I reproduced the failure in a minimal pages app on nuxt-nightly@5.0.0-2611121224-0568af6. Adding vue-router@^5.5.0 makes it build again. Older nightlies already shipped vue-router@^5.5.0 as a dependency, so this range matches them too.

via @mydea.

--

View Session [Sentry]

Nuxt 5 nightlies moved vue-router from a dependency to an optional peer
dependency, so apps with a pages/ directory fail to build without it.

Co-Authored-By: Francesco Gringl-Novy <2411343+mydea@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report πŸ“¦

Compared: 26ffa45 (PR test merge using develop at 359fbe4)

Against: 359fbe4 (develop) Β· base run #65839

βœ… Baseline matches: this diff contains only this PR's changes.

Path Size % Change Change
@sentry/browser 30.04 kB - -
@sentry/browser - with treeshaking flags 28.23 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 28.12 kB - -
@sentry/browser (incl. Tracing) 52.2 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 52.2 kB - -
@sentry/browser (incl. Tracing, Profiling) 55.17 kB - -
@sentry/browser (incl. Tracing, Replay) 92.73 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 81.52 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 97.08 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 110.51 kB - -
@sentry/browser (incl. Feedback) 47.66 kB - -
@sentry/browser (incl. sendFeedback) 30.62 kB - -
@sentry/browser (incl. FeedbackAsync) 35.62 kB - -
@sentry/browser (incl. Metrics) 31.36 kB - -
@sentry/browser (incl. Logs) 31.64 kB - -
@sentry/browser (incl. Metrics & Logs) 32.3 kB - -
@sentry/react 32.04 kB - -
@sentry/react (incl. Tracing) 54.86 kB - -
@sentry/vue 38.21 kB - -
@sentry/vue (incl. Tracing) 55.14 kB - -
@sentry/svelte 30.05 kB - -
@sentry/remix (Remix 3 client bundle) 57.96 kB - -
CDN Bundle 31.79 kB - -
CDN Bundle (incl. Tracing) 52.58 kB - -
CDN Bundle (incl. Logs, Metrics) 34.58 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 55.14 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 75.61 kB - -
CDN Bundle (incl. Tracing, Replay) 90.63 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 93.25 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 96 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 98.6 kB - -
CDN Bundle - uncompressed 92.69 kB - -
CDN Bundle (incl. Tracing) - uncompressed 155.13 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 101.03 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 162.76 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 231.11 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 275.27 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 282.9 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 287.07 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 294.69 kB - -
@sentry/nextjs (client) 58.23 kB - -
@sentry/sveltekit (client) 53.26 kB - -
@sentry/core/server 44.53 kB - -
@sentry/core/browser 13.99 kB - -
@sentry/node 149.48 kB -0.01% -4 B πŸ”½
@sentry/node/import (ESM hook with diagnostics-channel injection) 83.3 kB - -
@sentry/node - without tracing 88.38 kB -0.01% -7 B πŸ”½
@sentry/node - without channel injection 138.45 kB -0.01% -2 B πŸ”½
@sentry/aws-serverless 97.29 kB -0.01% -5 B πŸ”½
@sentry/cloudflare (withSentry) - minified 204.35 kB - -
@sentry/cloudflare (withSentry) 474.32 kB - -
@sentry/nextjs/cloudflare (withSentry) - minified 229.66 kB - -

View base workflow run

@github-actions

Copy link
Copy Markdown
Contributor

Optional E2E tests

All optional checks were successful. 5 successful. See the run.

Successful checks
Check Status
βœ… CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (static / nuxt generate) Test (optional) Successful in 34s Details
βœ… CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (client source maps kept) Test (optional) Successful in 44s Details
βœ… CI: Optional E2E Tests / E2E nuxt-5 (tunnel-dev) Test (optional) Successful in 57s Details
βœ… CI: Optional E2E Tests / E2E nuxt-5-sourcemaps Test (optional) Successful in 36s Details
βœ… CI: Optional E2E Tests / E2E nuxt-5 Test (optional) Successful in 2m Details

@mydea
mydea marked this pull request as ready for review November 12, 2026 13:01
@mydea
mydea requested a review from a team November 12, 2026 13:01
@mydea
mydea merged commit 3e2f711 into develop Nov 12, 2026
58 checks passed
@mydea
mydea deleted the fix/e2e-nuxt-5-vue-router branch November 12, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant