Repository navigation
chore: Route reviews to timfish and RulaKhaled - #26444
Merged
Merged
Conversation
Add the contractors to the reviewer fallback pool and make them owners in .github/REVIEWERS: timfish for node, server-utils, and the bundler plugins, RulaKhaled for AI integrations. The framework team also owns the bundler plugins. Co-Authored-By: Francesco Gringl-Novy <2411343+mydea@users.noreply.github.com>
mydea
reviewed
Nov 17, 2026
Lets the AI rules add RulaKhaled on top of the existing owners instead of repeating them on every line.
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 2 not successful, 61 successful. See the run.
Successful checks
|
Contributor
size-limit report π¦Compared: 45ab380 (PR test merge using develop at d383066) Against: d383066 (develop) Β· base run #66362 β Baseline matches: this diff contains only this PR's changes.
|
assign-reviewers.test.mjs went over the 300-line max-lines limit.
nicohrubec
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
team-javascript-sdksplus both of them..github/REVIEWERS: @timfish ownsnode,server-utils, and the bundler plugins. @RulaKhaled is added on top of the existing owners for AI integrations (gen-AI instrumentation inserver-utils, the AI helpers incore, MCP server, Cloudflare agents, and the AI test suites and e2e apps).team-javascript-sdks-frameworkalso owns the bundler plugins.REVIEWERSsupports+rules. They never win the last-match, they only add their owners on top of the rule that did, so the AI rules don't have to repeat the existing owners.Why
Contractors can't be members of a GitHub team, so the reviewer script never picked them. The contractor list now lives in
junior-requesters.mjsnext toTEAM_SLUG, so the review gate and reviewer assignment use the same list.With
+rules, Rula joins the codeowner pool for AI files alongside the existing owners, but she isn't picked on every AI PR. If she should be the only codeowner for AI paths, turn those rules into normal (non-+) rules.via @mydea.
--
View Session [Sentry]