Skip to content

feat(cloudflare): Deprecate cacheClient option - #26494

Merged
JPeer264 merged 1 commit into
developfrom
feat/cloudflare-deprecate-cache-client
Nov 17, 2026
Merged

JPeer264 merged 1 commit into
developfrom
feat/cloudflare-deprecate-cache-client

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

What

Deprecates the cacheClient option of @sentry/cloudflare. The deprecation notice says it goes away in the next major (v12), and asks anyone who sets cacheClient: false to open an issue explaining why cacheClient: true doesn't work for them. A TODO(v12) marks the option for removal. Behavior is unchanged.

Why

In v12 the cached client should be the only mode, so the per-invocation client code paths can go. Asking cacheClient: false users to open an issue tells us which use cases the cached client still misses before we remove the escape hatch. The SDK's own reads of the option carry typescript/no-deprecated disables until then.

via @JPeer264.

--

View Session [Sentry]

The client cache will become the only behavior in v12. Users who set
`cacheClient: false` are asked to open an issue so we learn which use
cases the cached client does not cover before the option goes away.

Co-Authored-By: Jan Peer StΓΆcklmair <10677263+JPeer264@users.noreply.github.com>
@JPeer264
JPeer264 marked this pull request as ready for review November 17, 2026 15:12
@sentry-junior
sentry-junior Bot requested a review from JPeer264 November 17, 2026 15:12
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report πŸ“¦

Compared: 5fb7cbc (PR test merge using develop at d25e075)

Against: d25e075 (develop) Β· base run #66525

βœ… Baseline matches: this diff contains only this PR's changes.

Path Size % Change Change
@sentry/browser 30.12 kB - -
@sentry/browser - with treeshaking flags 28.32 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 28.22 kB - -
@sentry/browser (incl. Tracing) 52.3 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 52.3 kB - -
@sentry/browser (incl. Tracing, Profiling) 55.27 kB - -
@sentry/browser (incl. Tracing, Replay) 92.83 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 81.62 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 97.22 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 110.61 kB - -
@sentry/browser (incl. Feedback) 47.74 kB - -
@sentry/browser (incl. sendFeedback) 30.7 kB - -
@sentry/browser (incl. FeedbackAsync) 35.71 kB - -
@sentry/browser (incl. Metrics) 31.44 kB - -
@sentry/browser (incl. Logs) 31.72 kB - -
@sentry/browser (incl. Metrics & Logs) 32.38 kB - -
@sentry/react 32.13 kB - -
@sentry/react (incl. Tracing) 54.97 kB - -
@sentry/vue 38.31 kB - -
@sentry/vue (incl. Tracing) 55.26 kB - -
@sentry/svelte 30.13 kB - -
@sentry/remix (Remix 3 client bundle) 58.08 kB - -
CDN Bundle 31.89 kB - -
CDN Bundle (incl. Tracing) 52.72 kB - -
CDN Bundle (incl. Logs, Metrics) 34.68 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 55.28 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 75.72 kB - -
CDN Bundle (incl. Tracing, Replay) 90.74 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 93.34 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 96.11 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 98.7 kB - -
CDN Bundle - uncompressed 93.05 kB - -
CDN Bundle (incl. Tracing) - uncompressed 155.52 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 101.39 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 163.15 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 231.51 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 275.67 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 283.3 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 287.47 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 295.09 kB - -
@sentry/nextjs (client) 58.59 kB - -
@sentry/sveltekit (client) 53.59 kB - -
@sentry/core/server 44.8 kB - -
@sentry/core/browser 14.4 kB - -
@sentry/node 151.67 kB -0.01% -7 B πŸ”½
@sentry/node/import (ESM hook with diagnostics-channel injection) 83.33 kB - -
@sentry/node - without tracing 88.6 kB -0.01% -5 B πŸ”½
@sentry/node - without channel injection 140.63 kB -0.01% -1 B πŸ”½
@sentry/aws-serverless 98.97 kB -0.01% -7 B πŸ”½
@sentry/cloudflare (withSentry) - minified 206.94 kB - -
@sentry/cloudflare (withSentry) 480.32 kB - -
@sentry/nextjs/cloudflare (withSentry) - minified 232.31 kB - -

View base workflow run

@JPeer264
JPeer264 enabled auto-merge (squash) November 17, 2026 15:14
@JPeer264
JPeer264 disabled auto-merge November 17, 2026 15:14
@JPeer264
JPeer264 enabled auto-merge (squash) November 17, 2026 15:15
@JPeer264
JPeer264 merged commit 4202227 into develop Nov 17, 2026
273 of 274 checks passed
@JPeer264
JPeer264 deleted the feat/cloudflare-deprecate-cache-client branch November 17, 2026 15:16
@github-actions

Copy link
Copy Markdown
Contributor

Optional E2E tests

Some optional checks were not successful. They do not block the merge. 1 not successful, 36 successful. See the run.

Check Status
❌ CI: Optional E2E Tests / E2E nextjs-16-cacheComponents (cloudflare) Test (optional) Failing after 10m Details
Successful checks
Check Status
βœ… CI: Optional E2E Tests / E2E cloudflare-mastra Test (optional) Successful in 49s Details
βœ… CI: Optional E2E Tests / E2E cloudflare-agent Test (optional) Successful in 36s Details
βœ… CI: Optional E2E Tests / E2E nestjs-12 (latest) Test (optional) Successful in 1m Details
βœ… CI: Optional E2E Tests / E2E gen-ai-libraries Test (optional) Successful in 45s Details
βœ… CI: Optional E2E Tests / E2E nextjs-14 (latest) Test (optional) Successful in 1m Details
βœ… CI: Optional E2E Tests / E2E astro-7 Test (optional) Successful in 2m Details
βœ… CI: Optional E2E Tests / E2E gen-ai-libraries (cloudflare) Test (optional) Successful in 56s Details
βœ… CI: Optional E2E Tests / E2E nuxt-5 (kv-cache) Test (optional) Successful in 1m Details
βœ… CI: Optional E2E Tests / E2E cloudflare-think (ai v6) Test (optional) Successful in 57s Details
βœ… CI: Optional E2E Tests / E2E astro-7-static Test (optional) Successful in 1m Details
βœ… CI: Optional E2E Tests / E2E cloudflare-flue-send-to-sentry Test (optional) Successful in 2m Details
βœ… CI: Optional E2E Tests / E2E cloudflare-pi-durable (latest) Test (optional) Successful in 47s Details
βœ… CI: Optional E2E Tests / E2E nextjs-15 (latest) Test (optional) Successful in 3m Details
βœ… CI: Optional E2E Tests / E2E cloudflare-pi-durable Test (optional) Successful in 44s Details
βœ… CI: Optional E2E Tests / E2E cloudflare-think Test (optional) Successful in 54s Details
βœ… CI: Optional E2E Tests / E2E nextjs-15 (turbo) Test (optional) Successful in 2m Details
βœ… CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (client source maps kept) Test (optional) Successful in 36s Details
βœ… CI: Optional E2E Tests / E2E nuxt-5 Test (optional) Successful in 2m Details
βœ… CI: Optional E2E Tests / E2E cloudflare-workers-without-tracing-send-to-sentry Test (optional) Successful in 1m Details
βœ… CI: Optional E2E Tests / E2E nestjs-12 (bun) Test (optional) Successful in 53s Details
βœ… CI: Optional E2E Tests / E2E nuxt-5-sourcemaps Test (optional) Successful in 36s Details
βœ… CI: Optional E2E Tests / E2E nuxt-5-cloudflare Test (optional) Successful in 28s Details
βœ… CI: Optional E2E Tests / E2E nestjs-12 (cloudflare) Test (optional) Successful in 50s Details
βœ… CI: Optional E2E Tests / E2E nextjs-16-tunnel (cloudflare) Test (optional) Successful in 1m Details
βœ… CI: Optional E2E Tests / E2E cloudflare-workers-send-to-sentry Test (optional) Successful in 2m Details
βœ… CI: Optional E2E Tests / E2E nextjs-16 (vinext) Test (optional) Successful in 1m Details
βœ… CI: Optional E2E Tests / E2E nextjs-16 (cloudflare, latest) Test (optional) Successful in 2m Details
βœ… CI: Optional E2E Tests / E2E nextjs-orpc Test (optional) Successful in 1m Details
βœ… CI: Optional E2E Tests / E2E nextjs-16 (vinext, bun) Test (optional) Successful in 1m Details
βœ… CI: Optional E2E Tests / E2E nestjs-12 (deno) Test (optional) Successful in 53s Details
βœ… CI: Optional E2E Tests / E2E gen-ai-libraries (latest) Test (optional) Successful in 1m Details
βœ… CI: Optional E2E Tests / E2E supabase-nextjs Test (optional) Successful in 2m Details
βœ… CI: Optional E2E Tests / E2E nuxt-5 (development) Test (optional) Successful in 1m Details
βœ… CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (static / nuxt generate) Test (optional) Successful in 37s Details
βœ… CI: Optional E2E Tests / E2E nuxt-5-tunnel Test (optional) Successful in 49s Details
βœ… CI: Optional E2E Tests / E2E tanstackstart-react-cloudflare Test (optional) Successful in 35s Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants