Repository navigation
feat(cloudflare): Deprecate cacheClient option - #26494
Merged
Merged
Conversation
The client cache will become the only behavior in v12. Users who set `cacheClient: false` are asked to open an issue so we learn which use cases the cached client does not cover before the option goes away. Co-Authored-By: Jan Peer StΓΆcklmair <10677263+JPeer264@users.noreply.github.com>
JPeer264
marked this pull request as ready for review
November 17, 2026 15:12
javascript-sdk-gitflow
Bot
requested review from
RulaKhaled,
andreiborza and
isaacs
November 17, 2026 15:12
nicohrubec
approved these changes
Nov 17, 2026
Contributor
size-limit report π¦Compared: 5fb7cbc (PR test merge using develop at d25e075) Against: d25e075 (develop) Β· base run #66525 β Baseline matches: this diff contains only this PR's changes.
|
JPeer264
enabled auto-merge (squash)
November 17, 2026 15:14
JPeer264
disabled auto-merge
November 17, 2026 15:14
JPeer264
enabled auto-merge (squash)
November 17, 2026 15:15
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 not successful, 36 successful. See the run.
Successful checks
|
51 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deprecates the
cacheClientoption of@sentry/cloudflare. The deprecation notice says it goes away in the next major (v12), and asks anyone who setscacheClient: falseto open an issue explaining whycacheClient: truedoesn't work for them. ATODO(v12)marks the option for removal. Behavior is unchanged.Why
In v12 the cached client should be the only mode, so the per-invocation client code paths can go. Asking
cacheClient: falseusers to open an issue tells us which use cases the cached client still misses before we remove the escape hatch. The SDK's own reads of the option carrytypescript/no-deprecateddisables until then.via @JPeer264.
--
View Session [Sentry]