Repository navigation
Reject empty tables during XML parsing - #2923
Merged
Merged
Conversation
Return an error for tables without rows or cells so malformed XML cannot reach table construction or clipboard indexing.
Owner
|
Thanks @acts-1631 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Table XML is parsed by CtStorageXmlHelper::populate_table_matrix()
before _create_table_from_xml() constructs the table widget. With no
row elements, the parser called tableMatrix.back() on an empty vector.
The clipboard path could also index an unvalidated empty matrix.
Return failure for tables without rows or cells, and handle that result
before table construction or clipboard indexing. This prevents a
crafted document or clipboard payload from crashing CherryTree through
out-of-bounds access while preserving valid tables.