[Swivelgames]

Partially completes #1128

See GDScript: Add @export_storage annotation godotengine/godot#82122 added in Godot 4.3

Adds the ability to annotate a field with @export_storage:

#[derive(GodotClass)]
#[class(base=RigidBody3D)]
struct Vehicle {
    /// Equivalent to:
    /// ```gdscript
    /// @export_storage var steering_angle: float
    /// ```
    #[export(storage)]
    steering_angle: f64,

    base: Base<RigidBody3D>
}

[Bromeon]

Thanks a lot for your contribution! 👍

I would probably merge the other changes to exports #1166 first, which might cause small merge conflicts, but I expect it wouldn't be difficult to resolve. Maybe you can already rebase onto that branch 🙂

Regarding failing CI, you can run tests locally, see Dev tools and testing.

[GodotRust]

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1183

[Swivelgames]

Awesome! @Bromeon It turns out that this is more involved than I had initially expected. @export_storage modifies the PropertyUsageFlags of the property, so I may have to do a bit more refactoring. I'll have something pushed up soon! 🙌

[Swivelgames]

I was having issues running itest, but it's because I forgot to set CARGO_TARGET_DIR=target.

To save space, I have my CARGO_TARGET_DIR set to ~/.cache/cargo/target by default. Oops 😅

I'm able to run them now. I'll address the issues I found 👍

Original Post

@Bromeon ./check.sh test seems to be passing, but itest fails for me with:

./check.sh itest                                                                                                                                  130 ↵
Checks to run: itest

Found 'godot' executable with version 4.4.1.stable.arch_linux
> cargo build -p itest --no-default-features
   Compiling godot-codegen v0.2.4 (./gdext/godot-codegen)
   Compiling godot-macros v0.2.4 (./gdext/godot-macros)
   Compiling godot-ffi v0.2.4 (./gdext/godot-ffi)
   Compiling godot-core v0.2.4 (./gdext/godot-core)
   Compiling itest v0.0.0 (./gdext/itest/rust)
   Compiling godot v0.2.4 (./gdext/godot)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.31s
> godot --path itest/godot --headless -- \[\]
ERROR: Condition "!FileAccess::exists(path)" is true. Returning: ERR_FILE_NOT_FOUND
   at: open_dynamic_library (drivers/unix/os_unix.cpp:893)
ERROR: GDExtension dynamic library not found: 'res://itest.gdextension'.
   at: open_library (core/extension/gdextension.cpp:701)
ERROR: Error loading extension: 'res://itest.gdextension'.
   at: load_extensions (core/extension/gdextension_manager.cpp:291)
Godot Engine v4.4.1.stable.arch_linux - https://godotengine.org

SCRIPT ERROR: Parse Error: Identifier "IntegrationTests" not declared in the current scope.
          at: GDScript::reload (res://TestRunner.gd:41)
ERROR: Failed to load script "res://TestRunner.gd" with error "Parse error".
   at: load (modules/gdscript/gdscript.cpp:3022)

[Swivelgames]

Tests are working with Godot 4.4. I'll try and see if I can downgrade my Godot version to test with older versions and make sure everything is good to go 👍

[Swivelgames]

Final fixes in place. Tests are passing for Godot 4.1, 4.2, 4.3, and 4.4 🙌

Also tested in my current project, and @export_storage is behaving correctly 👍

[Swivelgames]

Rebased from master now that #1166 has been merged, resolved conflicts, and still passing on 4.1-4.4 👍

[Swivelgames]

I was doing an unnecessary #[cfg()]. Wasn't critical, but it was unnecessary. Just removed it. Still passing on 4.1-4.4.

No more changes incoming 👍

[Bromeon]

Thanks a lot!

[Bromeon]

Thanks a lot for your contribution, and congrats to the first merged PR! 😊