Repository navigation
helpers: Consolidate MakeSegment vs MakePathSanitized - #5282
Merged
Merged
Conversation
bep
force-pushed
the
make-path-consolidate
branch
from
October 3, 2018 10:20
9aa3317 to
205dc55
Compare
bep
force-pushed
the
make-path-consolidate
branch
3 times, most recently
from
October 3, 2018 10:37
6e0280a to
a282492
Compare
In short: * Avoid double tolower in MakeSegment * Use MakePathSanitized for taxonomies in pageToPermalinkTitle; this matches what MakeSegment does. * Move the "double hyphen and space" logic into UnicodeSanitize The last bullet may be slightly breaking for some that now does not get the "--" in some URLs, but we need to reduce the amount of URL logic. See gohugoio#4926
bep
force-pushed
the
make-path-consolidate
branch
from
October 3, 2018 13:04
a282492 to
628bac4
Compare
Contributor
|
Everything works fine with this PR on my end. 👍 P.S. Wow! This is the 3rd time today that I compiled Hugo from source because of all the new commits. Your hard work is very much appreciated! 🥇 |
Contributor
|
Does this fix #3577? |
Contributor
|
@max-arnold, potentially. If you can test it before I do, let me know. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In short:
The last bullet may be slightly breaking for some that now does not get the "--" in some URLs, but we need to reduce the amount of URL logic.
See #4926