Skip to content

os: TestOpenError fails on some plan9 builders #70440

Closed

Description

@millerresearch

Go version

gotip

Output of go env in your module/workspace:

AR='ar'
 CC='gcc'
 CGO_CFLAGS='-O2 -g'
 CGO_CPPFLAGS=''
 CGO_CXXFLAGS='-O2 -g'
 CGO_ENABLED='0'
 CGO_FFLAGS='-O2 -g'
 CGO_LDFLAGS='-O2 -g'
 CXX='g++'
 GCCGO='gccgo'
 GO111MODULE=''
 GO386='sse2'
 GOARCH='386'
 GOAUTH='netrc'
 GOBIN=''
 GOCACHE='/home/swarming/luci/386/.swarming/w/ir/x/w/gocache'
 GODEBUG=''
 GOENV='/home/swarming/luci/386/.config/go/env'
 GOEXE=''
 GOEXPERIMENT=''
 GOFLAGS=''
 GOGCCFLAGS='-fPIC -m32 -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/home/swarming/luci/386/.swarming/w/ir/x/t/go-build2873492059=/tmp/go-build -gno-record-gcc-switches'
 GOHOSTARCH='amd64'
 GOHOSTOS='linux'
 GOINSECURE=''
 GOMOD='/dev/null'
 GOMODCACHE='/home/swarming/luci/386/.swarming/w/ir/x/w/gopath/pkg/mod'
 GONOPROXY=''
 GONOSUMDB=''
 GOOS='plan9'
 GOPATH='/home/swarming/luci/386/.swarming/w/ir/x/w/gopath'
 GOPRIVATE=''
 GOPROXY='https://proxy.golang.org,direct'
 GOROOT='/home/swarming/luci/386/.swarming/w/ir/x/w/goroot'
 GOSUMDB='sum.golang.org'
 GOTELEMETRY='local'
 GOTELEMETRYDIR='/home/swarming/luci/386/.config/go/telemetry'
 GOTMPDIR=''
 GOTOOLCHAIN='local'
 GOTOOLDIR='/home/swarming/luci/386/.swarming/w/ir/x/w/goroot/pkg/tool/linux_amd64'
 GOVCS=''
 GOVERSION='devel 400433af3660905ecaceaf19ddad3e6c24b141df'
 GOWORK=''
 PKG_CONFIG='pkg-config'

What did you do?

LUCI tests, for example ci/gotip-plan9-386

What did you see happen?

Example log:

=== RUN   TestOpenError
=== PAUSE TestOpenError
=== CONT  TestOpenError
    os_test.go:1830: Open("is-a-dir", 1) = _, "'/tmp/TestOpenError845272514/001/is-a-dir' permission denied"; want suffix "is a directory"
--- FAIL: TestOpenError (0.00s)

What did you expect to see?

Different Plan 9 file servers return different error strings (some arguably incorrect) when a process attempts to write to a directory. TestOpenError changed in CL 620157 to use a directory in /tmp instead of using the root file system. This may fail on Plan 9, depending on which file server is used to provide `/tmp'.
The test already has a special case for Plan 9's idiosyncratic error messages, but needs to allow for more possibilities.

Activity

  1. gopherbot commented on Nov 19, 2024

    @gopherbot
    Contributor

    Change https://go.dev/cl/629635 mentions this issue: os: allow for variant plan9 error messages in TestOpenError

  2. added
    NeedsFixThe path to resolution is known, but the work has not been done.
    FixPendingIssues that have a fix which has not yet been reviewed or submitted.
    on Nov 22, 2024
  3. added this to the Go1.24 milestone on Nov 22, 2024
  4. locked and limited conversation to collaborators on Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

FixPendingIssues that have a fix which has not yet been reviewed or submitted.FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.OS-Plan9

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions