Repository navigation
Refactor showBenchmarkButton configuration to isBenchmarkSupported and showBenchmarkActionButton - #1080
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_962444757
branch
from
August 11, 2026 21:07
62cec69 to
1dd3d31
Compare
…` and `showBenchmarkActionButton` * Renamed legacy `showBenchmarkButton` in `ModelItem` and data layer properties to `isBenchmarkSupported`. * Removed `showBenchmarkButton` from `Model.kt` data class. It is no longer in use. * Added `showBenchmarkActionButton` parameter to `ModelItem` to control whether the benchmark button should be shown as a prominent action button. Set this to true in global model manager. * Filtered overlapping benchmark entries in `ModelItemActionMenu` dropdown context menu. PiperOrigin-RevId: 962996561
copybara-service
Bot
force-pushed
the
test_962444757
branch
from
August 11, 2026 21:19
1dd3d31 to
84c90c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
showBenchmarkButtonconfiguration toisBenchmarkSupportedandshowBenchmarkActionButtonshowBenchmarkButtoninModelItemand data layer properties toisBenchmarkSupported.showBenchmarkButtonfromModel.ktdata class. It is no longer in use.showBenchmarkActionButtonparameter toModelItemto control whether the benchmark button should be shown as a prominent action button. Set this to true in global model manager.ModelItemActionMenudropdown context menu.