Skip to content

Lombok causes an IndexOutOfBoundsException in UnnecessarySemicolonΒ #5548

Closed

Description

@pzygielo

https://github.com/eclipse-ee4j/openmq/actions/runs/22488407428/job/65143797675?pr=2889#step:5:135:

Error:  /home/runner/work/openmq/openmq/mq/main/mqcomm-util/src/main/java/com/sun/messaging/jmq/util/selector/SelectorToken.java:[27,1] An unhandled exception was thrown by the Error Prone static analysis plugin.
     Please report this at https://github.com/google/error-prone/issues/new and include the following, as well as a reproducing code sample (if possible):
  
     error-prone version: 2.48.0
     BugPattern: UnnecessarySemicolon
     Stack Trace:
     java.lang.IndexOutOfBoundsException: Range [4507, 2437) out of bounds for length 4510
  	at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:100)
  	at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckFromToIndex(Preconditions.java:112)
  	at java.base/jdk.internal.util.Preconditions.checkFromToIndex(Preconditions.java:349)
  	at java.base/java.util.Objects.checkFromToIndex(Objects.java:391)
  	at java.base/java.nio.HeapCharBuffer.subSequence(HeapCharBuffer.java:731)
  	at java.base/java.nio.HeapCharBuffer.subSequence(HeapCharBuffer.java:48)
  	at com.google.errorprone.VisitorState.getOffsetTokens(VisitorState.java:543)
  	at com.google.errorprone.bugpatterns.UnnecessarySemicolon.matchClass(UnnecessarySemicolon.java:95)
  	at com.google.errorprone.scanner.ErrorProneScanner.processMatchers(ErrorProneScanner.java:541)
  	at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:650)
  	at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:180)
  	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:899)
  	at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:92)
  	at com.google.errorprone.scanner.Scanner.scan(Scanner.java:74)
  	at com.google.errorprone.scanner.Scanner.scan(Scanner.java:48)
  	at jdk.compiler/com.sun.source.util.TreeScanner.scan(TreeScanner.java:110)
  	at jdk.compiler/com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:118)
  	at jdk.compiler/com.sun.source.util.TreeScanner.visitCompilationUnit(TreeScanner.java:151)
  	at com.google.errorprone.scanner.ErrorProneScanner.visitCompilationUnit(ErrorProneScanner.java:663)
  	at com.google.errorprone.scanner.ErrorProneScanner.visitCompilationUnit(ErrorProneScanner.java:180)
  	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCCompilationUnit.accept(JCTree.java:627)
  	at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:66)
  	at com.google.errorprone.scanner.Scanner.scan(Scanner.java:58)
  	at com.google.errorprone.scanner.ErrorProneScannerTransformer.apply(ErrorProneScannerTransformer.java:43)
  	at com.google.errorprone.ErrorProneAnalyzer.finished(ErrorProneAnalyzer.java:231)
  	at jdk.compiler/com.sun.tools.javac.api.MultiTaskListener.finished(MultiTaskListener.java:133)
  	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1423)
  	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1370)
  	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:955)
  	at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.lambda$doCall$0(JavacTaskImpl.java:104)
  	at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.invocationHelper(JavacTaskImpl.java:152)
  	at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:100)
  	at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:94)
  	at org.codehaus.plexus.compiler.javac.JavaxToolsCompiler.compileInProcess(JavaxToolsCompiler.java:126)
  	at org.codehaus.plexus.compiler.javac.JavacCompiler.performCompile(JavacCompiler.java:337)
  	at org.apache.maven.plugin.compiler.AbstractCompilerMojo.executeReal(AbstractCompilerMojo.java:1236)
  	at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:708)
  	at org.apache.maven.plugin.compiler.CompilerMojo.execute(CompilerMojo.java:235)
  	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:126)
  	at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:328)
  	at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:316)
  	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
  	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:174)
  	at org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:75)
  	at org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:162)
  	at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
  	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:159)
  	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:105)
  	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:73)
  	at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:53)
  	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:118)
  	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:261)
  	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:173)
  	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:101)
  	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:919)
  	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:285)
  	at org.apache.maven.cli.MavenCli.main(MavenCli.java:207)
  	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
  	at java.base/java.lang.reflect.Method.invoke(Method.java:565)
  	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:255)
  	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:201)
  	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:361)
  	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:314)

Activity

  1. pzygielo commented on Feb 27, 2026

    @pzygielo
    ContributorAuthor

    I'm seeing the same exception on different but much simpler project with much much simpler (than SelectorToken) class (i.e. it shall be easily reproducible and I can prepare reproducer should it be needed).

  2. cushon commented on Feb 27, 2026

    @cushon
    Collaborator

    it shall be easily reproducible and I can prepare reproducer should it be needed

    Thanks for the report, a repro would be helpful if you're able to provide one.

  3. pzygielo commented on Feb 27, 2026

    @pzygielo
    ContributorAuthor

    Common factor:

    import lombok.Getter;
    ...
    @Getter
    ...
  4. cushon commented on Feb 27, 2026

    @cushon
    Collaborator

    Thanks, I suspect the crash is caused by lombok and has a similar root cause to the issue discussed in #4918 (comment)

  5. pzygielo commented on Feb 27, 2026

    @pzygielo
    ContributorAuthor
  6. changed the title [-]2.48.0/UnnecessarySemicolon: unhandled `IndexOutOfBoundsException`[/-] [+]Lombok causes an IndexOutOfBoundsException in UnnecessarySemicolon[/+] on Feb 27, 2026
  7. cushon commented on Feb 27, 2026

    @cushon
    Collaborator

    I'll leave this open as a separate issue since it affects a different check

  8. reopened this on Feb 27, 2026
  9. ben-manes commented on Feb 28, 2026

    @ben-manes

    I received this error in Caffeine, which does not use lombok. It fails on the region byte p000,. This snippet is for cache line padding to protect a volatile field from false sharing.

    Java snippet
    final class BLCHeader {
    
      private BLCHeader() {}
    
      @SuppressWarnings("unused")
      static class PadDrainStatus {
        byte p000, p001, p002, p003, p004, p005, p006, p007;
        byte p008, p009, p010, p011, p012, p013, p014, p015;
        byte p016, p017, p018, p019, p020, p021, p022, p023;
        byte p024, p025, p026, p027, p028, p029, p030, p031;
        byte p032, p033, p034, p035, p036, p037, p038, p039;
        byte p040, p041, p042, p043, p044, p045, p046, p047;
        byte p048, p049, p050, p051, p052, p053, p054, p055;
        byte p056, p057, p058, p059, p060, p061, p062, p063;
        byte p064, p065, p066, p067, p068, p069, p070, p071;
        byte p072, p073, p074, p075, p076, p077, p078, p079;
        byte p080, p081, p082, p083, p084, p085, p086, p087;
        byte p088, p089, p090, p091, p092, p093, p094, p095;
        byte p096, p097, p098, p099, p100, p101, p102, p103;
        byte p104, p105, p106, p107, p108, p109, p110, p111;
        byte p112, p113, p114, p115, p116, p117, p118, p119;
      }
    Stacktrace
    > Task :caffeine:compileJava FAILED
    /Users/ben/projects/caffeine/caffeine/src/main/java/com/github/benmanes/caffeine/cache/BoundedLocalCache.java:4625: error: An unhandled exception was thrown by the Error Prone static analysis plugin.
      static class PadDrainStatus {
             ^
         Please report this at https://github.com/google/error-prone/issues/new and include the following, as well as a reproducing code sample (if possible):
    
         error-prone version: 2.48.0
         BugPattern: UnnecessarySemicolon
         Stack Trace:
         java.lang.IndexOutOfBoundsException: Range [163836, 163826) out of bounds for length 166814
            at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:100)
            at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckFromToIndex(Preconditions.java:112)
            at java.base/jdk.internal.util.Preconditions.checkFromToIndex(Preconditions.java:349)
            at java.base/java.util.Objects.checkFromToIndex(Objects.java:391)
            at java.base/java.nio.HeapCharBuffer.subSequence(HeapCharBuffer.java:731)
            at java.base/java.nio.HeapCharBuffer.subSequence(HeapCharBuffer.java:48)
            at com.google.errorprone.VisitorState.getOffsetTokens(VisitorState.java:543)
            at com.google.errorprone.bugpatterns.UnnecessarySemicolon.matchClass(UnnecessarySemicolon.java:95)
            at com.google.errorprone.scanner.ErrorProneScanner.processMatchers(ErrorProneScanner.java:541)
            at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:650)
            at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:180)
            at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:899)
            at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:92)
            at com.google.errorprone.scanner.Scanner.scan(Scanner.java:74)
            at com.google.errorprone.scanner.Scanner.scan(Scanner.java:48)
            at jdk.compiler/com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:95)
            at jdk.compiler/com.sun.source.util.TreeScanner.scan(TreeScanner.java:110)
            at jdk.compiler/com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:118)
            at jdk.compiler/com.sun.source.util.TreeScanner.visitClass(TreeScanner.java:202)
            at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:651)
            at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:180)
            at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:899)
            at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:92)
            at com.google.errorprone.scanner.Scanner.scan(Scanner.java:74)
            at com.google.errorprone.scanner.Scanner.scan(Scanner.java:48)
            at jdk.compiler/com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:95)
            at jdk.compiler/com.sun.source.util.TreeScanner.scan(TreeScanner.java:110)
            at jdk.compiler/com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:118)
            at jdk.compiler/com.sun.source.util.TreeScanner.visitCompilationUnit(TreeScanner.java:151)
            at com.google.errorprone.scanner.ErrorProneScanner.visitCompilationUnit(ErrorProneScanner.java:663)
            at com.google.errorprone.scanner.ErrorProneScanner.visitCompilationUnit(ErrorProneScanner.java:180)
            at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCCompilationUnit.accept(JCTree.java:627)
            at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:66)
            at com.google.errorprone.scanner.Scanner.scan(Scanner.java:58)
            at com.google.errorprone.scanner.ErrorProneScannerTransformer.apply(ErrorProneScannerTransformer.java:43)
            at com.google.errorprone.ErrorProneAnalyzer.finished(ErrorProneAnalyzer.java:231)
            at jdk.compiler/com.sun.tools.javac.api.MultiTaskListener.finished(MultiTaskListener.java:133)
            at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1423)
            at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1370)
            at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:955)
            at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.lambda$doCall$0(JavacTaskImpl.java:104)
            at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.invocationHelper(JavacTaskImpl.java:152)
            at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:100)
            at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:94)
            at org.gradle.internal.compiler.java.IncrementalCompileTask.call(IncrementalCompileTask.java:92)
            at org.gradle.api.internal.tasks.compile.AnnotationProcessingCompileTask.call(AnnotationProcessingCompileTask.java:94)
            at org.gradle.api.internal.tasks.compile.ResourceCleaningCompilationTask.call(ResourceCleaningCompilationTask.java:57)
            at org.gradle.api.internal.tasks.compile.JdkJavaCompiler.execute(JdkJavaCompiler.java:83)
            at org.gradle.api.internal.tasks.compile.JdkJavaCompiler.execute(JdkJavaCompiler.java:50)
            at org.gradle.api.internal.tasks.compile.daemon.AbstractIsolatedCompilerWorkerExecutor$CompilerWorkAction.execute(AbstractIsolatedCompilerWorkerExecutor.java:80)
            at org.gradle.workers.internal.DefaultWorkerServer.execute(DefaultWorkerServer.java:68)
            at org.gradle.workers.internal.AbstractClassLoaderWorker$1.create(AbstractClassLoaderWorker.java:54)
            at org.gradle.workers.internal.AbstractClassLoaderWorker$1.create(AbstractClassLoaderWorker.java:48)
            at org.gradle.internal.classloader.ClassLoaderUtils.executeInClassloader(ClassLoaderUtils.java:102)
            at org.gradle.workers.internal.AbstractClassLoaderWorker.executeInClassLoader(AbstractClassLoaderWorker.java:48)
            at org.gradle.workers.internal.FlatClassLoaderWorker.run(FlatClassLoaderWorker.java:32)
            at org.gradle.workers.internal.FlatClassLoaderWorker.run(FlatClassLoaderWorker.java:22)
            at org.gradle.workers.internal.WorkerDaemonServer.run(WorkerDaemonServer.java:108)
            at org.gradle.workers.internal.WorkerDaemonServer.run(WorkerDaemonServer.java:77)
            at org.gradle.process.internal.worker.request.WorkerAction.lambda$run$1(WorkerAction.java:150)
            at org.gradle.process.internal.worker.child.WorkerLogEventListener.withWorkerLoggingProtocol(WorkerLogEventListener.java:41)
            at org.gradle.process.internal.worker.request.WorkerAction.lambda$run$2(WorkerAction.java:150)
            at org.gradle.internal.operations.CurrentBuildOperationRef.with(CurrentBuildOperationRef.java:84)
            at org.gradle.process.internal.worker.request.WorkerAction.run(WorkerAction.java:142)
            at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
            at java.base/java.lang.reflect.Method.invoke(Method.java:565)
            at org.gradle.internal.dispatch.MethodInvocation.invokeOn(MethodInvocation.java:77)
            at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:28)
            at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:19)
            at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:182)
            at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:164)
            at org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:414)
            at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
            at org.gradle.internal.concurrent.AbstractManagedExecutor$1.run(AbstractManagedExecutor.java:47)
            at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1090)
            at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:614)
            at java.base/java.lang.Thread.run(Thread.java:1474)
    1 error
  10. cushon commented on Feb 28, 2026

    @cushon
    Collaborator

    Thanks for the report!

    For multi-variable declarations like byte p000, p001, p002, p003, p004, p005, p006, p007; the parser lowers them into separate declarations, and each synthetic declaration has the original start position and a different end position, so the source ranges for each declaration overlap and that breaks assumptions in UnnecessarySemicolon. I'll fix it.

  11. cushon commented on Mar 3, 2026

    @cushon
    Collaborator

    #5548 (comment) is fixed by ad78428, and I also made the error messages for this a bit better: 6f7268d. I think that should have taken care of the original problem as well, the check will now skip over cases where the source positions would be invalid.

  12. pzygielo commented on Apr 7, 2026

    @pzygielo
    ContributorAuthor

    I think that should have taken care of the original problem as well,

    with EP:2.49.0 I'm getting (for @Getter line):

    [WARNING] COMPILATION WARNING : 
    .... .java:[9,3] [UnnecessarySemicolon] Unnecessary semicolons should be omitted. For empty block statements, prefer {}.
    

    which is no longer reported as error, indeed, but with fail on warning build - it still fails of course.


  13. ThoSap commented on Oct 22, 2026

    @ThoSap

    The crash is fixed, but the false positive that @pzygielo described is still there in 2.51.0, and the suggested fix removes a semicolon that is required.

    Minimal reproduction (Error Prone 2.51.0, Lombok 1.18.48, JDK 25.0.4, only UnnecessarySemicolon enabled):

    package repro;
    
    import lombok.Getter;
    import lombok.Setter;
    
    @Getter
    @Setter
    public class Semicolon {
        private String first = "";
        private String second = "";
    }
    Semicolon.java:7: error: [UnnecessarySemicolon] Unnecessary semicolons should be omitted. For empty block statements, prefer {}.
    @Setter
    ^
      Did you mean 'private String first = ""'?
    Semicolon.java:7: error: [UnnecessarySemicolon] Unnecessary semicolons should be omitted. For empty block statements, prefer {}.
    @Setter
    ^
      Did you mean 'private String second = ""'?
    

    The positions of the class members after Lombok has run (printed with a small javac plugin, TreeInfo.getStartPos and TreeInfo.getEndPos):

    Member Start End Source at that range
    <init>() (javac default constructor) 84 -1
    first 106 132 private String first = "";
    second 137 164 private String second = "";
    getFirst() (Lombok) 121 132 first = "";
    getSecond() (Lombok) 152 164 second = "";
    setFirst() (Lombok) 69 76 @Setter
    setSecond() (Lombok) 69 76 @Setter

    setSecond() is the last member, and hasExplicitSource accepts it because its start and end differ.
    So matchClass scans the tokens from offset 76 to the end of the class, finds the ; of both fields, and reports them on the @Setter line.

    With lombok.addLombokGeneratedAnnotation = true, the result is the same: every generated member carries @lombok.Generated, but the check does not look at it.
    An idea, not tested: in matchClass, skip a member (as current or next) that has a @Generated annotation (lombok.Generated, javax.annotation.processing.Generated).
    That would cover member-level checks such as this one, independent of how the end positions are fixed (see projectlombok/lombok#3917).

    Should I open a new issue for the false positive, as this one is closed?

    Related: #6232 (TraditionalJavadocToMarkdown with Lombok), projectlombok/lombok#3917.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions