You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Delete local copies of LongAdder/Striped64 in favor of java.util.concurrent.atomic.LongAdderΒ #3183
changed the title [-]find two same `Striped64.java` files in guava, is this intentional ?[/-][+]Find some same files in guava , is this intentional ?[/+]on Jun 15, 2018
Yep, we don't want them to be public APIs, so the only way to use them in both packages is to make 2 copies.
What I didn't realize is that LongAdder actually made its way into Java8. I suspect we can delete our copies of Striped64 and LongAdder in our Java8 branch. @lowasser ?
changed the title [-]Find some same files in guava , is this intentional ?[/-][+]Delete local copies of LongAdder/Striped64 in favor of java.util.concurrent.atomic.LongAdder[/+]on Jun 15, 2018
Activity
[-]find two same `Striped64.java` files in guava, is this intentional ?[/-][+]Find some same files in guava , is this intentional ?[/+]kluever commentedon Jun 15, 2018
Yep, we don't want them to be public APIs, so the only way to use them in both packages is to make 2 copies.
What I didn't realize is that
LongAdderactually made its way into Java8. I suspect we can delete our copies ofStriped64andLongAdderin our Java8 branch. @lowasser ?[-]Find some same files in guava , is this intentional ?[/-][+]Delete local copies of LongAdder/Striped64 in favor of java.util.concurrent.atomic.LongAdder[/+]lowasser commentedon Jun 15, 2018
I think this would break GWT/J2CL.