Skip to content

Delete local copies of LongAdder/Striped64 in favor of java.util.concurrent.atomic.LongAdderΒ #3183

Open

Description

@mjd507

in the package com.google.common.hash and com.google.common.cache,
some files like LongAddable, LongAddables, LongAdder, and Striped64 are the same.

Activity

  1. changed the title [-]find two same `Striped64.java` files in guava, is this intentional ?[/-] [+]Find some same files in guava , is this intentional ?[/+] on Jun 15, 2018
  2. kluever commented on Jun 15, 2018

    @kluever
    Member

    Yep, we don't want them to be public APIs, so the only way to use them in both packages is to make 2 copies.

    What I didn't realize is that LongAdder actually made its way into Java8. I suspect we can delete our copies of Striped64 and LongAdder in our Java8 branch. @lowasser ?

  3. changed the title [-]Find some same files in guava , is this intentional ?[/-] [+]Delete local copies of LongAdder/Striped64 in favor of java.util.concurrent.atomic.LongAdder[/+] on Jun 15, 2018
  4. lowasser commented on Jun 15, 2018

    @lowasser
    Contributor

    I think this would break GWT/J2CL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions