Skip to content

Fix index.md - #822

Closed
jl0x61 wants to merge 1 commit into
google:masterfrom
jl0x61:bugFix
Closed

jl0x61 wants to merge 1 commit into
google:masterfrom
jl0x61:bugFix

Conversation

@jl0x61

@jl0x61 jl0x61 commented Jul 14, 2020 •

Copy link
Copy Markdown
Contributor

Remove return value of GetApproximateSizes in index.md.
The return type of DB::GetApproximateSizes is void:

virtual void GetApproximateSizes(const Range* range, int n,
                                 uint64_t* sizes) = 0;

remove return value of GetApproximateSizes in index.md
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jl0x61

jl0x61 commented Jul 14, 2020

Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jl0x61 jl0x61 changed the title Update index.md Fix index.md Jul 14, 2020
@cmumford

Copy link
Copy Markdown
Contributor

Nice catch @jl0x61. I'll get this merged.

@cmumford

Copy link
Copy Markdown
Contributor

Merged. thx.

@cmumford cmumford closed this Jul 15, 2020
cmumford added a commit that referenced this pull request Jul 15, 2020
PiperOrigin-RevId: 321372819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants