Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

chore: configure Renovate Bot for dependencies.properties - #1749

Merged
meltsufin merged 1 commit into
mainfrom
deps-renovate
Jul 29, 2022
Merged

meltsufin merged 1 commit into
mainfrom
deps-renovate

Conversation

@meltsufin

Copy link
Copy Markdown
Contributor

@meltsufin
meltsufin requested review from a team and blakeli0 July 28, 2022 21:07
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Comment thread renovate.json
"datasourceTemplate": "maven"
},
{
"fileMatch": ["^dependencies\\.properties$"],

@blakeli0 blakeli0 Jul 28, 2022 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this version is used, it's currently hardcoded to 1.7 here

@meltsufin meltsufin Jul 29, 2022 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be used by Bazel build though here. We should probably update build.gradle to use the property too.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks! Yes we should, we are removing Gradle soon but this is a quick fix anyway.

@meltsufin
meltsufin merged commit 7c3164f into main Jul 29, 2022
@meltsufin
meltsufin deleted the deps-renovate branch July 29, 2022 12:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants