Skip to content

This repo does not compile in jdk9 #3027

Closed

Description

@jeanbza

Note: This might just be that I'm super rusty at java and am missing something silly.

When I set my JAVA_HOME to a jdk9 path and mvn compile, I get:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:check (checkstyle) on 
project google-cloud-pom: Execution checkstyle of goal 
org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:check failed: Plugin 
org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0 or one of its dependencies could 
not be resolved: Could not find artifact com.sun:tools:jar:1.7.0 at specified path
/Library/Java/JavaVirtualMachines/jdk-9.0.1.jdk/Contents/Home/../lib/tools.jar -> [Help 1]

When I set my JAVA_HOME to a jdk8 path and mvn compile, it works.

This seems to be a known issue with checkstyle. I'm not sure how org.apache.maven.plugins » maven-checkstyle-plugin (which we use) relates to github.com/checkstyle/checkstyle; their versioning seems quite different (github latest is 8.8, whereas maven latest is 3.0.0 ).

edit: the difference between the two seems to be that the github one is the checkstyle project itself, and the maven thing is just a maven plugin possibly using the checkstyle project?

Activity

  1. added
    type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
    priority: p2Moderately-important priority. Fix may not be included in next release.
    on Mar 14, 2018
  2. pongad commented on Mar 14, 2018

    @pongad
    Contributor

    I'm not quite sure how to categorize this. Provisionally giving it P2, but please bump if you think it's more urgent.

  3. removed
    🚨 criticalP0 critical issue. Requires immediate fix
    priority: p2Moderately-important priority. Fix may not be included in next release.
    on Oct 9, 2018
  4. chingor13 commented on Dec 4, 2018

    @chingor13
    Contributor

    This repo compiles with Java 11 and we'll be supporting official GA Java versions moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions