Repository navigation
Add Macaron checks for GitHub Actions workflows - #865
Conversation
444e0a2 to
1fadfd9
Compare
2625c5a to
9d290c7
Compare
behnazh-w
left a comment
There was a problem hiding this comment.
To help Dependabot bumping the version and improve readability, it is a common practice to add the version string as a comment next to the commit SHA. I have added version strings in my comments wherever missing.
|
Thanks for pointing this out. I added the |
|
@behnazh-w The requested changes have been applied and pushed, and I resolved the review threads. This PR is ready for another look when you have a chance. Thanks again for the review. |
92d7015 to
282a9fd
Compare
|
@behnazh-w @jormundur00 This PR has been squashed, the review comments are addressed, and it is ready to merge. |
|
|
||
| GitHub workflow and composite action files (`.github/workflows/**` and `.github/actions/**`) are checked by the `Check GitHub Actions with Macaron` workflow. | ||
| The check uses the Macaron `check-github-actions` policy with `policy_purl` set to `pkg:github.com/graalvm/native-build-tools@.*` (see [Macaron GitHub Action documentation](https://oracle.github.io/macaron/pages/macaron_action.html)). | ||
| This check should remain a required pull request status check for the default branch. |
There was a problem hiding this comment.
Small nit: Maybe this should specify that it's a "required status check when actions/workflows are touched", as the workflow doesn't trigger if those paths aren't touched. "Required" gates usually mean they must complete for every PR.
|
Addressed the nit by clarifying that the Macaron check should be required when PRs touch GitHub workflow or composite action files, since the workflow is path-filtered. |
….1 to 1.1.2 [skip ci] Bumps [org.graalvm.buildtools:native-maven-plugin](https://github.com/graalvm/native-build-tools) from 1.1.1 to 1.1.2. Release notes *Sourced from [org.graalvm.buildtools:native-maven-plugin's releases](https://github.com/graalvm/native-build-tools/releases).* > 1.1.2 > ----- > > What's Changed > -------------- > > * Release 1.1.1 by [`@graalvmbot`](https://github.com/graalvmbot) in [graalvm/native-build-tools#898](https://redirect.github.com/graalvm/native-build-tools/pull/898) > * Bump version to 1.1.2-SNAPSHOT by [`@graalvmbot`](https://github.com/graalvmbot) in [graalvm/native-build-tools#899](https://redirect.github.com/graalvm/native-build-tools/pull/899) > * Add Macaron checks for GitHub Actions workflows by [`@vjovanov`](https://github.com/vjovanov) in [graalvm/native-build-tools#865](https://redirect.github.com/graalvm/native-build-tools/pull/865) > * Add plugin descriptions by [`@ban-mi`](https://github.com/ban-mi) in [graalvm/native-build-tools#876](https://redirect.github.com/graalvm/native-build-tools/pull/876) > * Add grund repository specification by [`@jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#894](https://redirect.github.com/graalvm/native-build-tools/pull/894) > * Update reachability metadata to 1.0.3 by [`@graalvmbot`](https://github.com/graalvmbot) in [graalvm/native-build-tools#918](https://redirect.github.com/graalvm/native-build-tools/pull/918) > > **Full Changelog**: <graalvm/native-build-tools@1.1.1...1.1.2> Commits * [`bb7ec92`](graalvm/native-build-tools@bb7ec92) Release 1.1.2 * [`0bd82d7`](graalvm/native-build-tools@0bd82d7) Merge pull request [#918](https://redirect.github.com/graalvm/native-build-tools/issues/918) from graalvm/update-metadata-to-1.0.3 * [`f3b0fc3`](graalvm/native-build-tools@f3b0fc3) Update reachability metadata to 1.0.3 * [`0373c8b`](graalvm/native-build-tools@0373c8b) Add grund repository specification ([#894](https://redirect.github.com/graalvm/native-build-tools/issues/894)) * [`31deced`](graalvm/native-build-tools@31deced) Merge pull request [#876](https://redirect.github.com/graalvm/native-build-tools/issues/876) from graalvm/bm/add-goal-descriptions-to-plugins * [`2cd3fb0`](graalvm/native-build-tools@2cd3fb0) Merge pull request [#865](https://redirect.github.com/graalvm/native-build-tools/issues/865) from vjovanov/vj/issue-864-macaron-checks * [`596f1ff`](graalvm/native-build-tools@596f1ff) Clarify Macaron check requirement * [`282a9fd`](graalvm/native-build-tools@282a9fd) Add Macaron checks for GitHub Actions workflows * [`d839662`](graalvm/native-build-tools@d839662) Add plugin descriptions * [`c8b8ee8`](graalvm/native-build-tools@c8b8ee8) Merge pull request [#899](https://redirect.github.com/graalvm/native-build-tools/issues/899) from graalvm/bump-version-to-1.1.2-SNAPSHOT * Additional commits viewable in [compare view](graalvm/native-build-tools@1.1.1...1.1.2)
Summary
Testing
Fixes #864