You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Validate wrappers for all Gradle nightlies published at https://services.gradle.org/distributions-snapshots/Β #281
This is a prerequisite for using the action in any repository that makes use of nightlies.
This is a prerequisite for dogfooding in the gradle org which makes heavy use of nightlies.
Currently, the action consumes https://services.gradle.org/versions/all which contains information about the latest nightly and the latest release nightly only. All other nightlies are missing.
The services.gradle.org versions API only provides details on latest nightly (and release nightly), so wouldn't the API need to be enhanced first? Is there another source for this?
Do you mean by reading the HTML and looking for the links? Or is there another way? I'd have thought that would be a little fragile, and failures to parse would have to fail the action if validation has been enabled (though given it's for nightlies failures are relatively lower impact, and any issue would surely be fixed quickly especially if it's impacting Gradle's own builds).
I'm not volunteering to build a PR since I'm unfamiliar with TypeScript but the pointers might help someone with the right experience. It would be nice to unblock #12 for v4.
Yes, that's what I meant. The HTML is a generated directory listing and should be generally stable over time.
We would only fail the build if all of the following were true:
Wrapper jar is NOT in the set of known checksums hard-coded into the action. These hardcoded values represent what was in https://services.gradle.org/versions/all at the time of release.
Wrapper jar is NOT found currently in https://services.gradle.org/versions/all, or we fail to read from that source. Any Gradle versions released since gradle/actions was released should be present here.
I'm not sure about getting #14 into v4, but you're right that it would be nice.
I now wish I'd released v4.0.0-beta.1 instead of going straight to an RC!
Activity
3flex commentedon Jul 22, 2024
The services.gradle.org versions API only provides details on latest nightly (and release nightly), so wouldn't the API need to be enhanced first? Is there another source for this?
bigdaz commentedon Jul 22, 2024
While not ideal, it should be possible to extract the wrapper checksums by traversing the directory listing at https://services.gradle.org/distributions-snapshots/
3flex commentedon Jul 22, 2024
Do you mean by reading the HTML and looking for the links? Or is there another way? I'd have thought that would be a little fragile, and failures to parse would have to fail the action if validation has been enabled (though given it's for nightlies failures are relatively lower impact, and any issue would surely be fixed quickly especially if it's impacting Gradle's own builds).
I'm not volunteering to build a PR since I'm unfamiliar with TypeScript but the pointers might help someone with the right experience. It would be nice to unblock #12 for v4.
bigdaz commentedon Jul 22, 2024
Yes, that's what I meant. The HTML is a generated directory listing and should be generally stable over time.
We would only fail the build if all of the following were true:
gradle/actionswas released should be present here.I think this would be acceptable.
I'm not sure about getting #14 into
v4, but you're right that it would be nice.I now wish I'd released
v4.0.0-beta.1instead of going straight to an RC!Verify wrappers for distribution-snapshots
Verify wrappers for distribution-snapshots
Verify wrappers for distribution-snapshots