Skip to content

Remove unnecessary dependency overrides - #981

Merged
bigdaz merged 2 commits into
mainfrom
remove-unnecessary-overrides
Jun 10, 2026
Merged

bigdaz merged 2 commits into
mainfrom
remove-unnecessary-overrides

Conversation

@bigdaz

@bigdaz bigdaz commented Jun 10, 2026

Copy link
Copy Markdown
Member

Removes all overrides from sources/package.json. Two commits, each independently verified:

1. Remove redundant security overrides

The shell-quote, fast-xml-parser, fast-xml-builder and eslint > brace-expansion overrides added in #980 are no-ops: npm's natural resolution already lands on the exact same patched versions, so they upgrade nothing. The vulnerabilities were actually resolved by regenerating the lockfile, not by the overrides.

2. Remove obsolete Octokit/Azure overrides

@azure/logger, @octokit/request, @octokit/request-error and @octokit/plugin-paginate-rest were point-in-time pins added to force-upgrade then-vulnerable transitive deps (5d947f4, #601). The parent packages (@actions/github, @actions/artifact) have since advanced and now resolve newer, non-vulnerable versions naturally — so the overrides only pinned stale versions:

Package Pinned (override) Natural
@octokit/request 8.4.1 10.0.10
@octokit/request-error 5.1.1 7.1.0
@octokit/plugin-paginate-rest 9.2.2 14.0.0
@azure/logger 1.1.4 1.3.0

Verification

  • npm audit → 0 vulnerabilities
  • ./build → passes
  • npm test → 352/352 passing

Note on a flaky test

While testing I saw the wrapper-validation test "fetches wrapper jar checksums for snapshots" intermittently fail (1–2 failures, then pass on retry). It is a pre-existing flaky network test — it makes ~175 live calls to Gradle services and sits right at its 60s timeout. Its code path imports neither Octokit nor Azure (src/wrapper-validation/ uses only @actions/http-client/nock/cheerio), so it is unrelated to these overrides; the nock/@mswjs/interceptors/undici versions are identical before and after.

🤖 Generated with Claude Code

bigdaz and others added 2 commits June 9, 2026 18:21
The shell-quote, fast-xml-parser, fast-xml-builder and eslint>brace-expansion
overrides added in #980 are no-ops: npm's natural resolution already lands on
the same patched versions, so they upgrade nothing. The vulnerabilities were
actually resolved by regenerating the lockfile. Verified `npm audit` still
reports 0 vulnerabilities after removal.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The @azure/logger, @octokit/request, @octokit/request-error and
@octokit/plugin-paginate-rest overrides were added as point-in-time pins to
force-upgrade then-vulnerable transitive dependencies (5d947f4, #601). The
parent packages (@actions/github, @actions/artifact) have since moved forward
and now resolve newer, non-vulnerable versions naturally, so the overrides
only serve to pin stale versions (e.g. @octokit/request 8.4.1 vs 10.0.10).

Removing them:
- npm audit reports 0 vulnerabilities
- ./build passes
- full test suite passes (352/352)

The one intermittent failure observed during testing (wrapper-validation
"fetches wrapper jar checksums for snapshots") is a pre-existing flaky network
test that hits live Gradle services near its 60s timeout; it passes on retry
and its code path imports neither Octokit nor Azure, so it is unrelated to
these overrides.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@bigdaz
bigdaz merged commit 9901393 into main Jun 10, 2026
129 checks passed
@bigdaz
bigdaz deleted the remove-unnecessary-overrides branch June 10, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant