Repository navigation
Remove unnecessary dependency overrides - #981
Merged
Merged
Conversation
The shell-quote, fast-xml-parser, fast-xml-builder and eslint>brace-expansion overrides added in #980 are no-ops: npm's natural resolution already lands on the same patched versions, so they upgrade nothing. The vulnerabilities were actually resolved by regenerating the lockfile. Verified `npm audit` still reports 0 vulnerabilities after removal. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The @azure/logger, @octokit/request, @octokit/request-error and @octokit/plugin-paginate-rest overrides were added as point-in-time pins to force-upgrade then-vulnerable transitive dependencies (5d947f4, #601). The parent packages (@actions/github, @actions/artifact) have since moved forward and now resolve newer, non-vulnerable versions naturally, so the overrides only serve to pin stale versions (e.g. @octokit/request 8.4.1 vs 10.0.10). Removing them: - npm audit reports 0 vulnerabilities - ./build passes - full test suite passes (352/352) The one intermittent failure observed during testing (wrapper-validation "fetches wrapper jar checksums for snapshots") is a pre-existing flaky network test that hits live Gradle services near its 60s timeout; it passes on retry and its code path imports neither Octokit nor Azure, so it is unrelated to these overrides. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all
overridesfromsources/package.json. Two commits, each independently verified:1. Remove redundant security overrides
The
shell-quote,fast-xml-parser,fast-xml-builderandeslint > brace-expansionoverrides added in #980 are no-ops: npm's natural resolution already lands on the exact same patched versions, so they upgrade nothing. The vulnerabilities were actually resolved by regenerating the lockfile, not by the overrides.2. Remove obsolete Octokit/Azure overrides
@azure/logger,@octokit/request,@octokit/request-errorand@octokit/plugin-paginate-restwere point-in-time pins added to force-upgrade then-vulnerable transitive deps (5d947f4, #601). The parent packages (@actions/github,@actions/artifact) have since advanced and now resolve newer, non-vulnerable versions naturally — so the overrides only pinned stale versions:@octokit/request@octokit/request-error@octokit/plugin-paginate-rest@azure/loggerVerification
npm audit→ 0 vulnerabilities./build→ passesnpm test→ 352/352 passingNote on a flaky test
While testing I saw the
wrapper-validationtest "fetches wrapper jar checksums for snapshots" intermittently fail (1–2 failures, then pass on retry). It is a pre-existing flaky network test — it makes ~175 live calls to Gradle services and sits right at its 60s timeout. Its code path imports neither Octokit nor Azure (src/wrapper-validation/uses only@actions/http-client/nock/cheerio), so it is unrelated to these overrides; thenock/@mswjs/interceptors/undiciversions are identical before and after.🤖 Generated with Claude Code