Repository navigation
Scope CI-integ-test concurrency groups per-branch - #983
Merged
Merged
Conversation
The concurrency groups used fixed names spanning all branches, so a push
to main could cancel a pending PR run (and vice versa), leaving PRs not
fully tested.
Append ${{ github.ref }} to each group so runs only supersede pending
runs on the same branch, while different branches run in parallel. Also
drop the `queue: max` key, which is not a valid GitHub Actions
concurrency option and was ignored.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
ci-integ-test.ymlworkflow uses concurrency groups to limit parallel test runs. The groups used fixed names (CI-integ-test-caching, etc.) with no branch component, so every run across every branch shared a group. Withcancel-in-progress: false, GitHub keeps one in-progress + one pending run per group and cancels the previously-pending run when a new one arrives — regardless of branch. The side effect: a push tomaincould cancel a pending PR run (and vice versa), leaving PRs not fully tested.Change
${{ github.ref }}to each concurrency group. Runs now only supersede pending runs on the same branch; different branches get independent groups and run in parallel.queue: maxkey — it's not a valid GitHub Actions concurrency option (onlygroupandcancel-in-progressare honored) and was being ignored.Behaviour after this change
mainno longer disturbs a PR run.Note: per-ref scoping means the
pull_requestandpushevents for a PR branch (differentgithub.ref) won't dedupe against each other; this is intentional per the requested approach.🤖 Generated with Claude Code