Repository navigation
balancer: remove grpc.lb.pick_first.* metrics - #9215
Conversation
…ubchannel metrics
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9215 +/- ##
==========================================
- Coverage 83.11% 83.03% -0.09%
==========================================
Files 423 423
Lines 35231 35224 -7
==========================================
- Hits 29284 29247 -37
- Misses 4432 4450 +18
- Partials 1515 1527 +12
🚀 New features to boost your workflow:
|
|
@mbissa @arjan-bal @Pranjali-2501 @easwars Sorry for pinging everyone like this, but I'd really appreciate it if someone could take a quick look and review this when you have a chance. Thanks! |
| if holds[1].Wait(ctx) != true { | ||
| t.Fatalf("Timeout waiting for server %d with address %q to be contacted", 1, addrs[1]) | ||
| } | ||
| if got, _ := tmr.Metric("grpc.lb.pick_first.connection_attempts_failed"); got != 1 { |
There was a problem hiding this comment.
@mbissa : For all of these removed lines, what was the original plan? Would the pick_first tests continue to track the subchannel metrics or did we plan to have other tests that would track with these metrics?
There was a problem hiding this comment.
The plan was to move the tests to different place which is more apt for subchannel and not keep them in pickfirst.
|
@deepgolani4 can you please move the tests to a separate place in the otel package where we run e2e tests instead of changing just the existing tests. |
@mbissa Moved the OTel e2e metric coverage into stats/opentelemetry/e2e_test.go, and removed the duplicate pickfirst metric tests from balancer/pickfirst. |
easwars
left a comment
There was a problem hiding this comment.
LGTM, modulo one minor nit
| ss := &stubserver.StubServer{ | ||
| EmptyCallF: func(context.Context, *testpb.Empty) (*testpb.Empty, error) { | ||
| return &testpb.Empty{}, nil | ||
| }, | ||
| } | ||
| ss.StartServer() |
There was a problem hiding this comment.
Nit: This could be replaced with a single line call to stubserver.StartTestService
|
@deepgolani4 : Any updates on this one? Thanks |
CI vet.sh fails because 'go mod tidy -compat=1.25' under go1.25 removes stale h1 hashes from the go.sum files of the stats/opencensus, security/advancedtls and security/advancedtls/examples modules. These entries are identical on upstream master; retidy them here so the vet check passes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sorry for the delay, i've pushed the relevant changes. |
Fixes #8752
The changes remove the three grpc.lb.pick_first.* metric registrations and their recording calls from pickfirst.go (along with the now-unneeded metricsRecorder/target fields), then update all tests and examples to assert on the equivalent grpc.subchannel.* metrics instead.
RELEASE NOTES:
grpc.lb.pick_first.*metrics.