You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Configuration validators allow invalid configurations to be submitted #1301
The configuration UI prints a red warning message if invalid configuration options are provided, but the user is still able to submit invalid configurations. This could lead to unpredictable behavior, which is not acceptable for a production-safe simulation.
Example:
If you submit "1.3" as an IP address, you will be warned that it is invalid, but allowed to submit it anyway. Linux expands this to 1.0.0.3, while Windows does not recognize it as a valid IP address. 1.0.0.3 is likely not what you meant when you entered "1.3", so the monkey will be scanning hosts you did not intend. This behavior is both unpredictable and inconsistent across platforms.
To Reproduce
Steps to reproduce the behavior:
Open the configuration screen on Monkey Island
Input an invalid IP address in the network tab
Click "submit"
Export the config in plaintext and inspect the config to verify that the invalid IP address was added to the configuration.
Expected behavior
Users should not be able to submit invalid configurations.
Tasks
Gray out "submit" button if config is invalid (1.25d) @cakekoa@VakarisZ
Activity
Changelog: Add an entry for #1301, #2989