## Describe the bug It seems that we are leaking OTP in Hadoop payload logging ## To Reproduce Steps to reproduce the behavior: 1. Configure the Monkey with Hadoop plugin 2. Run the monkey on any hadoop machine 3. Observe logs ## Expected behavior We shouldn't be logging OTP. ## Screenshots <img width="1337" alt="image" src="https://user-images.githubusercontent.com/15820737/235936996-9a4fc4d1-3598-439a-acdb-a63add6a42b3.png"> ## Machine version (please complete the following information): - OS: Windows or Linux ## Tasks - [ ] Fix up logging level in Hadoop plugin - [ ] Do not forget to rebuild the plugin - [ ] Fix the regex in OTPFormatter - [ ] Store the OTP character set in `common` and use it in `OTPFormatter` and `AuthenticationFacade.generate_otp()` - [ ] Compile regexes as class variables so they don't need to be recompiled for every single log message
Activity
shreyamalviya commentedon May 3, 2023
The regex in
OTPFormatterneeds to be fixed.mssalvatore commentedon May 3, 2023
We should also consider modifying the plugin to not leak this in the first place.
mssalvatore commentedon May 3, 2023
A few improvements that can be made:
commonso the regex and thegenerate_otp()function are kept in syncformat()function is called.Changelog: Add an entry for #3296
Changelog: Add an entry for #3296
Changelog: Add an entry for #3296
Changelog: Add an entry for #3296
Changelog: Add an entry for #3296
Merge branch '3296-fix-hadoop-otp-leak' into develop