Skip to content

Island stuck on version update #857

Closed

Description

@VakarisZ

Describe the bug

If island has no connection to the internet, the version update gets stuck waiting for the timeout and user can't do anything on the island on the meantime. Related #858

To Reproduce

Steps to reproduce the behavior:

  1. Run island without internet connection
  2. Refresh the island page
  3. On each refresh island tries to query for version update and hangs until timeout is reached. Hanging occurs because Tornado WSGI container (as noted in a warning here) is blocking/synchronous server. All other requests doesn't get parsed until version update timeout is reached and execution gets resumed.

Expected behavior

Version update process should happen in parallel with other activities on the island.

Activity

  1. added
    BugAn error, flaw, misbehavior or failure in the Monkey or Monkey Island.
    on Oct 12, 2020
  2. acepace commented on Oct 14, 2020

    @acepace
    Contributor

    Why not just add a real timeout (say less than 10 seconds)? This is anyway a good practice regardless of gevent.

  3. VakarisZ commented on Oct 15, 2020

    @VakarisZ
    ContributorAuthor

    Current timeout is already set (to 15 seconds I think).

  4. VakarisZ commented on Jan 22, 2021

    @VakarisZ
    ContributorAuthor

    Hopefully gevent solved this for good

  5. mssalvatore commented on Jan 22, 2021

    @mssalvatore
    Collaborator

    Hopefully gevent solved this for good

    Have we run a test to try and reproduce this since the gevent changes?

  6. VakarisZ commented on Jan 27, 2021

    @VakarisZ
    ContributorAuthor

    Just checked, it's solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugAn error, flaw, misbehavior or failure in the Monkey or Monkey Island.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions