Skip to content

SSL warnings #859

Closed
Closed

Description

@VakarisZ

Describe the bug

image

To Reproduce

Steps to reproduce the behavior:

  1. Configure the Monkey Island on AWS (maybe happens elsewhere too?)

Expected behavior

Should not be throwing warnings.

Tasks

References

https://stackoverflow.com/questions/66364650/catching-errors-being-thrown-within-module

Activity

  1. added
    BugAn error, flaw, misbehavior or failure in the Monkey or Monkey Island.
    on Oct 12, 2020
  2. acepace commented on Oct 14, 2020

    @acepace
    Contributor

    Can't avoid that while using self signed certs. Without control over who's running the island, GC shouldn't sign a blanket cert.

  3. VakarisZ commented on Oct 15, 2020

    @VakarisZ
    ContributorAuthor

    I agree with you, but maybe we can ignore/catch the warnings in order not to litter the log and not to confuse users.

  4. acepace commented on Oct 19, 2020

    @acepace
    Contributor

    Ah, hmm.
    This will go away once you use gevent as this warning comes from tornado.

  5. mxm0z commented on Dec 17, 2020

    @mxm0z

    I'm having the same issue. I even tried with different environments - debian, vmware, docker. All the same. How can I use gevent to fix this? It's not clear

  6. VakarisZ commented on Dec 18, 2020

    @VakarisZ
    ContributorAuthor

    @mxm0z You can't (unless you're running a dev version) but we will on the next release. Also, AFAIK this should not impact your usage of the tool, simply spams the logs.

  7. VakarisZ commented on Jan 22, 2021

    @VakarisZ
    ContributorAuthor

    Still happens with gevent, let's try to catch it

  8. mssalvatore commented on Feb 23, 2021

    @mssalvatore
    Collaborator

    Since we switched to gevent, the error looks like:
    image

  9. removed their assignment
    on Jul 1, 2021
  10. added 2 commits that reference this issue on Jul 5, 2021
    94c27e0
    7684120
  11. mssalvatore commented on Jul 5, 2021

    @mssalvatore
    Collaborator

    After spending some time with this, I don't think we should entirely suppress this warning. Since users can now provide their own certificates, this could be useful information for them.

    What we do need is to prevent the traceback from being displayed in the console output. PR #1298 proposes a solution.

  12. added 2 commits that reference this issue on Jul 5, 2021
    16de12b
    96fc330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugAn error, flaw, misbehavior or failure in the Monkey or Monkey Island.Complexity: LowImpact: High

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions