Skip to content

Fix reset env state bug - #666

Merged
VakarisZ merged 1 commit into
developfrom
665/reset-env-button-state-bug
May 27, 2020
Merged

VakarisZ merged 1 commit into
developfrom
665/reset-env-button-state-bug

Conversation

@ShayNehmad

@ShayNehmad ShayNehmad commented May 27, 2020 •

Copy link
Copy Markdown
Contributor

😈

What is this?

Fixes #665. Thanks for reporting @ophirharpazg

Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Have you successfully tested your changes locally?
  • Is the TravisCI build passing?

Proof that it works

reset_env

Changes

Are the commit messages enough? If not, elaborate.

@ShayNehmad ShayNehmad added Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. UI User Interface labels May 27, 2020
@ShayNehmad ShayNehmad added this to the 1.9.0 milestone May 27, 2020
@ShayNehmad
ShayNehmad requested a review from VakarisZ May 27, 2020 07:16
@ShayNehmad ShayNehmad self-assigned this May 27, 2020
@ShayNehmad ShayNehmad changed the title We forgot to call onClose for the button ❕ Fix reset env state bug May 27, 2020
@codecov

codecov Bot commented May 27, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #666 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #666   +/-   ##
========================================
  Coverage    56.62%   56.62%           
========================================
  Files          120      120           
  Lines         4044     4044           
========================================
  Hits          2290     2290           
  Misses        1754     1754           

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update ffda4e8...090beb6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. UI User Interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reset Environment popup shows only once

2 participants