Skip to content

Linux deployment scripts tweaks - #900

Merged
mssalvatore merged 12 commits into
guardicore:developfrom
mssalvatore:linux-deployment-scripts-tweaks
Dec 9, 2020
Merged

mssalvatore merged 12 commits into
guardicore:developfrom
mssalvatore:linux-deployment-scripts-tweaks

Conversation

@mssalvatore

@mssalvatore mssalvatore commented Dec 8, 2020 •

Copy link
Copy Markdown
Collaborator

What does this PR do?

Fixes a number of issues with deployment_scripts/deploy_linux.sh.

The deployment_scripts/deploy_linux.sh is not often used. As such, it has fallen into a state of disrepair. These commits fix a number of installation failures, as well as update some documentation to improve the overall experience of using the linux deployment script.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running the deploy_linux.sh script on an Ubuntu 18.04 VM

  • If applicable, add screenshots or log transcripts of the feature working

@acepace acepace left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not use apt as it has an unstable CLI interface.
https://manpages.debian.org/buster/apt/apt.8.en.html#SCRIPT_USAGE_AND_DIFFERENCES_FROM_OTHER_APT_TOOLS

Other than that, changes look good.

@mssalvatore

mssalvatore commented Dec 8, 2020 •

Copy link
Copy Markdown
Collaborator Author

We should not use apt as it has an unstable CLI interface.

@acepace Good call. I'll push a fix tomorrow.

`apt-get` has a stable command-line interface, while `apt` does not.
@mssalvatore
mssalvatore merged commit 44fd1ab into guardicore:develop Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants