Repository navigation
Linux deployment scripts tweaks - #900
Merged
mssalvatore merged 12 commits intoDec 9, 2020
Merged
mssalvatore merged 12 commits into
mssalvatore merged 12 commits into
Conversation
If the user is root, we want to exit as soon as possible since any commands that the deployment script runs will be run as root.
acepace
reviewed
Dec 8, 2020
acepace
left a comment
Contributor
There was a problem hiding this comment.
We should not use apt as it has an unstable CLI interface.
https://manpages.debian.org/buster/apt/apt.8.en.html#SCRIPT_USAGE_AND_DIFFERENCES_FROM_OTHER_APT_TOOLS
Other than that, changes look good.
Collaborator
Author
@acepace Good call. I'll push a fix tomorrow. |
`apt-get` has a stable command-line interface, while `apt` does not.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a number of issues with
deployment_scripts/deploy_linux.sh.The
deployment_scripts/deploy_linux.shis not often used. As such, it has fallen into a state of disrepair. These commits fix a number of installation failures, as well as update some documentation to improve the overall experience of using the linux deployment script.PR Checklist
Testing Checklist