Repository navigation
Replace document.write('<script ...>') with document.createElement('script') #9797
Description
GWT version: 2.10.0
Browser (with version): Chrome
Operating System: Version 109.0.5414.119 (Official Build) (x86_64)
Description
I'm using SingleScriptLinker to produce a single Javascript file, and the generated JS code contains:
$doc_0.write('<script id="' + markerId + '"><\/script>');
Which causes errors when the GWT output JS is used in a Chrome Extension:
Failed to execute 'write' on 'Document': It isn't possible to write into a document from an asynchronously-loaded external script unless it is explicitly opened.
According to the latest documentation about document.write:
https://developer.mozilla.org/en-US/docs/Web/API/Document/write
Use of the document.write() method is strongly discouraged.
I'm wondering if it's a good idea to replace the following two lines:
$doc.write('<script id="' + markerId + '"></script>');
markerScript = $doc.getElementById(markerId);
with:
markerScript = $doc.createElement('script');
markerScript.id = markerId;
$doc.body.appendChild(markerScript);
If this makes sense, there are a few other script templates needing similar changes.
https://github.com/gwtproject/gwt/search?q=%24doc.write%28%27%3Cscript&type=code
Steps to reproduce
Inspect the generated GWT Javascript code, you will see doc.write in it.
Known workarounds
I've tested the new template in a custom linker, which avoided document.write in the generated Javascript, hence eliminated such errors in Chrome Extension.
Activity
tbroyer commentedon Jan 30, 2023
If the gwt.xml has
<script>elements, they'll be injected usingdocument.writetoo (IIRC, this is/was to guarantee execution order):gwt/dev/core/src/com/google/gwt/core/ext/linker/impl/ResourceInjectionUtil.java
Lines 78 to 94 in 38cefc3
AFAICT, your proposed change won't work:
document.bodydoesn't exist yet)There's definitely room from improvement, and these templates are quite old, but if they don't work for you I'd suggest creating your own linker. But IIRC the xsiframe linker works for browser extensions and shouldn't use
document.write.jiakuan commentedon Jan 30, 2023
I was guessing probably
document.writewas used to guarantee execution order. If we could figure the correct place to inject thescripttag, then perhaps we could use the DOM API instead of thedocument.writeto create thescriptelement.Avoid document write in single script linker loading
Avoid document write in single script linker loading (gwtproject#9847)