Repository navigation
Added missed IOException to Reader.read(char[] buf) and Reader.read(c⦠- #9933
Merged
niloc132 merged 3 commits intoJul 30, 2024
Merged
Conversation
β¦har[] buf, int off, int len) methods
niloc132
approved these changes
Mar 2, 2024
Member
|
To land this, we're going to need to mark these as technically API-breaking changes in 2.12 - it is possible that someone was relying on them not throwing these exceptions and so was skipping the try/catch. First though we need to generate a 2.11 reference jar, so we can see what changes might happen, I'll get that fixed soon. |
Contributor
Author
|
@niloc132 It's not worth it! Let's close this PR, |
Member
|
No, that work should happen anyway, I'll get it done by the end of the week. |
Member
|
Once #9982 merges, we can finish this finally - after that lands, merge with main, and make this change to fix CI: diff --git a/tools/api-checker/config/gwt211_212userapi.conf b/tools/api-checker/config/gwt211_212userapi.conf
index 1279e029d8..ecd503d03d 100644
--- a/tools/api-checker/config/gwt211_212userapi.conf
+++ b/tools/api-checker/config/gwt211_212userapi.conf
@@ -149,4 +149,8 @@ excludedPackages com.google.gwt.core.client.impl\
##############################################
#Api whitelist
# when adding to the white-list, include comments as to why the addition is
-# being made.
\ No newline at end of file
+# being made.
+
+# java.io.Reader missing IOException throws for read methods
+java.io.Reader::read([C) OVERRIDABLE_METHOD_EXCEPTION_TYPE_CHANGE new method has more exceptions: [Ljava/io/IOException;]
+java.io.Reader::read([CII) OVERRIDABLE_METHOD_EXCEPTION_TYPE_CHANGE new method has more exceptions: [Ljava/io/IOException;] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
β¦har[] buf, int off, int len) methods
Fixes #9915