Repository navigation
remove first character for delegating args to CodeServer - #9940
Merged
Merged
Conversation
niloc132
approved these changes
Mar 20, 2024
niloc132
left a comment
niloc132
left a comment
Member
There was a problem hiding this comment.
LGTM, and I don't see another clear way to achieve this. The code as it stands doesn't appear very testable, so I'm leaning to merge as is, with a round of manual testing of the fix (maybe added to the release test plan too).
Contributor
Author
|
I like the solution not so because I check if it starts with a I can try to write a test to check that the generated Do you think it makes sense to do this? |
niloc132
approved these changes
Apr 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for #9939