Repository navigation
Fix when response.usage is None for some OpenRouter models - #1402
Merged
albertvillanova merged 4 commits intoJun 25, 2025
Merged
albertvillanova merged 4 commits into
albertvillanova merged 4 commits into
Conversation
Contributor
Author
|
Similar bug fix here: microsoft/autogen#1599 |
sentienthouseplant
changed the title
0 for prompt_tokens when response.usage is None.response.usage is None for OpenAI model.
albertvillanova
requested changes
Jun 2, 2025
Member
There was a problem hiding this comment.
Please note that we support streaming with our stream_outputs parameter:
- if True, we call
generate_streamand call the model withstream=True - if False, we call
generate, and the model is not called withstream=True
And according to OpenRouter docs, response.usage can only be None when passing stream=True, that is, when stream_outputs is True, and therefore when we call generate_stream. We don't call generate when streaming outputs.
Could you please provide an example raising the error in the reported issue:
Contributor
Author
|
Added traceback to the issue :) |
albertvillanova
changed the title
response.usage is None for OpenAI model.response.usage is None for some OpenRouter models
albertvillanova
approved these changes
Jun 25, 2025
albertvillanova
left a comment
albertvillanova
left a comment
Member
There was a problem hiding this comment.
Thanks!
Just did a minor refactoring.
maxwellfet928
pushed a commit
to maxwellfet928/smolagents
that referenced
this pull request
Jun 8, 2026
…ngface#1402) Co-authored-by: Albert Villanova del Moral <8515462+albertvillanova@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The openrouter API has
response.usageas optional, while the OpenAI API does not.Fixes #1401
Checks.
All commands from the
CONTRIBUTING.mdpass.Tests
689 passed