Repository navigation
Support multiple types in tool arguments validation - #1505
Merged
albertvillanova merged 4 commits intoJul 1, 2025
Merged
albertvillanova merged 4 commits into
albertvillanova merged 4 commits into
Conversation
albertvillanova
approved these changes
Jul 1, 2025
Contributor
Author
|
Thanks for fixing this, much better |
maxwellfet928
pushed a commit
to maxwellfet928/smolagents
that referenced
this pull request
Jun 8, 2026
Co-authored-by: Albert Villanova del Moral <8515462+albertvillanova@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the problem: I have an MCP server that is generated from an OpenAPI specification. In one of the input arguments of a tool, it has the type
[str, null]. In the argument validation,smolagentsonly allows a single type for each input argument. This small PR fixes this small issue.Other docstring changes are from my ruff formatter.