Repository navigation
Fix optional args toolcalling - #1538
Merged
Merged
Conversation
aymeric-roucher
force-pushed
the
fix-optional-args-toolcalling
branch
from
July 9, 2025 16:46
1a4461b to
702199d
Compare
albertvillanova
requested changes
Jul 10, 2025
Member
There was a problem hiding this comment.
I think there might be some confusion around the term "nullable" in this context.
We should clarify terminology: "nullable" can be interpreted in two ways:
- either that the argument can explicitly be set to None,
- or that it's optional in the sense that it has a default value and doesn't need to be passed at all.
I think that distinction is important when reasoning about how LLMs should construct tool arguments.
Collaborator
Author
|
|
albertvillanova
approved these changes
Jul 10, 2025
albertvillanova
left a comment
albertvillanova
left a comment
Member
There was a problem hiding this comment.
Thanks. I just added a complete test suite (some of them to be addressed in a subsequent PR).
maxwellfet928
pushed a commit
to maxwellfet928/smolagents
that referenced
this pull request
Jun 8, 2026
Co-authored-by: Albert Villanova del Moral <8515462+albertvillanova@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.